Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2355823002: CPDF_OCContext and CPDF_Document are no longer friends (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, npm, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

CPDF_OCContext and CPDF_Document are no longer friends Remove friendship as there doesn't appear to be anything protected that is being accessed by CPDF_OCContext. Committed: https://pdfium.googlesource.com/pdfium/+/8bd542690c3a0f56e20cd46e96c1ed7fed480690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M core/fpdfapi/fpdf_parser/include/cpdf_document.h View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-20 13:52:07 UTC) #4
npm
lgtm
4 years, 3 months ago (2016-09-20 14:38:32 UTC) #7
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-20 17:26:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355823002/1
4 years, 3 months ago (2016-09-20 19:36:23 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 19:36:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/8bd542690c3a0f56e20cd46e96c1ed7fed48...

Powered by Google App Engine
This is Rietveld 408576698