CPDF_Document and CPDF_DataAvail are no longer friends

CPDF_Document and CPDF_DataAvail are no longer friends

Remove the friendship between these two classes and replace with accessor
methods.

Committed: https://pdfium.googlesource.com/pdfium/+/23e173ad2c48e2683cd6e5f76da3fa188d85bcb8

[dsinclair, 2016-09-20 13:33:18]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 13:33:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-20 13:33:32]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-09-20 13:33:33]

PTAL.

[commit-bot: I haz the power, 2016-09-20 13:45:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 13:45:34]

Dry run: This issue passed the CQ dry run.

[npm, 2016-09-20 14:37:02]

lgtm

[Tom Sepez, 2016-09-20 17:26:04]

LGTM with nit.

https://codereview.chromium.org/2355813002/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right):

https://codereview.chromium.org/2355813002/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:516: bool
CPDF_Document::IsPageLoaded(int iPage) {
nit: const method.

[dsinclair, 2016-09-20 19:18:44]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-20 19:18:46]

The CQ bit was unchecked by dsinclair@chromium.org

[dsinclair, 2016-09-20 19:18:47]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-20 19:18:47]

The CQ bit was unchecked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:18:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-20 19:21:46]

https://codereview.chromium.org/2355813002/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right):

https://codereview.chromium.org/2355813002/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:516: bool
CPDF_Document::IsPageLoaded(int iPage) {
On 2016/09/20 17:26:04, Tom Sepez wrote:
> nit: const method.

Done.

[dsinclair, 2016-09-20 19:21:53]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-20 19:21:54]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2355813002/#ps20001
(title: "const")

[commit-bot: I haz the power, 2016-09-20 19:21:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:35:41]

Description was changed from

==========
CPDF_Document and CPDF_DataAvail are no longer friends

Remove the friendship between these two classes and replace with accessor
methods.
==========

to

==========
CPDF_Document and CPDF_DataAvail are no longer friends

Remove the friendship between these two classes and replace with accessor
methods.

Committed:
https://pdfium.googlesource.com/pdfium/+/23e173ad2c48e2683cd6e5f76da3fa188d85...
==========

[commit-bot: I haz the power, 2016-09-20 19:35:42]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/23e173ad2c48e2683cd6e5f76da3fa188d85...