Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: ios/chrome/browser/about_flags.mm

Issue 2355743004: Enable Spotlight Actions by default. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/experimental_flags.mm » ('j') | ios/chrome/browser/experimental_flags.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/about_flags.mm
diff --git a/ios/chrome/browser/about_flags.mm b/ios/chrome/browser/about_flags.mm
index 245253ec9915db6c7aaf4d66b4a4749e34844669..fd30c84139ddbccad7e603aee7e2859297ea1418 100644
--- a/ios/chrome/browser/about_flags.mm
+++ b/ios/chrome/browser/about_flags.mm
@@ -208,11 +208,9 @@ void AppendSwitchesFromExperimentalSettings(base::CommandLine* command_line) {
}
// Populate command line flag for Spotlight Actions.
- NSString* enableSpotlightActions =
- [defaults stringForKey:@"EnableSpotlightActions"];
- if ([enableSpotlightActions isEqualToString:@"Enabled"]) {
- command_line->AppendSwitch(switches::kEnableSpotlightActions);
- } else if ([enableSpotlightActions isEqualToString:@"Disabled"]) {
+ BOOL disableSpotlightActions =
+ [defaults boolForKey:@"DisableSpotlightActions"];
+ if (disableSpotlightActions) {
sdefresne 2016/09/20 16:56:22 You don't need the local variable here: if ([defa
jif 2016/09/20 18:34:57 Done.
command_line->AppendSwitch(switches::kDisableSpotlightActions);
}
« no previous file with comments | « no previous file | ios/chrome/browser/experimental_flags.mm » ('j') | ios/chrome/browser/experimental_flags.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698