Enable Spotlight Actions by default.

ios/chrome/browser/about_flags.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of about_flags for iOS that sets flags based on experimental
 // settings.
 
 #include "ios/chrome/browser/about_flags.h"
 
 #include <stddef.h>
@@ skipping 190 matching lines @@
   // Populate command line flag for the Payment Request API.
   NSString* enable_payment_request =
       [defaults stringForKey:@"EnablePaymentRequest"];
   if ([enable_payment_request isEqualToString:@"Enabled"]) {
     command_line->AppendSwitch(switches::kEnablePaymentRequest);
   } else if ([enable_payment_request isEqualToString:@"Disabled"]) {
     command_line->AppendSwitch(switches::kDisablePaymentRequest);
   }
 
   // Populate command line flag for Spotlight Actions.
-  NSString* enableSpotlightActions =
-      [defaults stringForKey:@"EnableSpotlightActions"];
-  if ([enableSpotlightActions isEqualToString:@"Enabled"]) {
-    command_line->AppendSwitch(switches::kEnableSpotlightActions);
-  } else if ([enableSpotlightActions isEqualToString:@"Disabled"]) {
+  BOOL disableSpotlightActions =
+      [defaults boolForKey:@"DisableSpotlightActions"];
+  if (disableSpotlightActions) {

[sdefresne, 2016/09/20 16:56:22]

You don't need the local variable here:

if ([defaults boolForKey:@"DisableSpotlightActions"]) {
  ...

[jif, 2016/09/20 18:34:57]

Done.

     command_line->AppendSwitch(switches::kDisableSpotlightActions);
   }
 
   // Freeform commandline flags.  These are added last, so that any flags added
   // earlier in this function take precedence.
   if ([defaults boolForKey:@"EnableFreeformCommandLineFlags"]) {
     base::CommandLine::StringVector flags;
     // Append an empty "program" argument.
     flags.push_back("");
 
@@ skipping 75 matching lines @@
 }
 
 namespace testing {
 
 const flags_ui::FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing