Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2355743004:
Enable Spotlight Actions by default. (Closed)
DescriptionEnable Spotlight Actions by default.
Matching downstream CL: https://chromereviews.googleplex.com/503587014/
Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647310
BUG=648529
Committed: https://crrev.com/e9171baf955613633d96be5c327010f011549e63
Cr-Commit-Position: refs/heads/master@{#419832}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Addressed comments. #Patch Set 3 : Fix compilation error. #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== Enable Spotlight Actions by default. BUG= ========== to ========== Enable Spotlight Actions by default. Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647310 BUG=648529 ==========
Description was changed from ========== Enable Spotlight Actions by default. Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647310 BUG=648529 ========== to ========== Enable Spotlight Actions by default. Matching downstream CL: https://chromereviews.googleplex.com/503587014/ Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647310 BUG=648529 ==========
jif@chromium.org changed reviewers: + sdefresne@chromium.org
ptal
lgtm with comments https://codereview.chromium.org/2355743004/diff/20001/ios/chrome/browser/abou... File ios/chrome/browser/about_flags.mm (right): https://codereview.chromium.org/2355743004/diff/20001/ios/chrome/browser/abou... ios/chrome/browser/about_flags.mm:213: if (disableSpotlightActions) { You don't need the local variable here: if ([defaults boolForKey:@"DisableSpotlightActions"]) { ... https://codereview.chromium.org/2355743004/diff/20001/ios/chrome/browser/expe... File ios/chrome/browser/experimental_flags.mm (right): https://codereview.chromium.org/2355743004/diff/20001/ios/chrome/browser/expe... ios/chrome/browser/experimental_flags.mm:190: if (command_line->HasSwitch(switches::kDisableSpotlightActions)) { return !command_line->HasSwitch(switches::kDisableSpotlightActions);
thanks
forgot to send the "Done" comments. Here we go. https://codereview.chromium.org/2355743004/diff/20001/ios/chrome/browser/abou... File ios/chrome/browser/about_flags.mm (right): https://codereview.chromium.org/2355743004/diff/20001/ios/chrome/browser/abou... ios/chrome/browser/about_flags.mm:213: if (disableSpotlightActions) { On 2016/09/20 16:56:22, sdefresne wrote: > You don't need the local variable here: > > if ([defaults boolForKey:@"DisableSpotlightActions"]) { > ... Done. https://codereview.chromium.org/2355743004/diff/20001/ios/chrome/browser/expe... File ios/chrome/browser/experimental_flags.mm (right): https://codereview.chromium.org/2355743004/diff/20001/ios/chrome/browser/expe... ios/chrome/browser/experimental_flags.mm:190: if (command_line->HasSwitch(switches::kDisableSpotlightActions)) { On 2016/09/20 16:56:22, sdefresne wrote: > return !command_line->HasSwitch(switches::kDisableSpotlightActions); Done.
The CQ bit was checked by jif@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2355743004/#ps40001 (title: "Addressed comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was checked by jif@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2355743004/#ps60001 (title: "Fix compilation error.")
Patchset #1 (id:1) has been deleted
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable Spotlight Actions by default. Matching downstream CL: https://chromereviews.googleplex.com/503587014/ Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647310 BUG=648529 ========== to ========== Enable Spotlight Actions by default. Matching downstream CL: https://chromereviews.googleplex.com/503587014/ Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647310 BUG=648529 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Enable Spotlight Actions by default. Matching downstream CL: https://chromereviews.googleplex.com/503587014/ Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647310 BUG=648529 ========== to ========== Enable Spotlight Actions by default. Matching downstream CL: https://chromereviews.googleplex.com/503587014/ Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647310 BUG=648529 Committed: https://crrev.com/e9171baf955613633d96be5c327010f011549e63 Cr-Commit-Position: refs/heads/master@{#419832} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e9171baf955613633d96be5c327010f011549e63 Cr-Commit-Position: refs/heads/master@{#419832} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
