Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2355673003: Gut gyp_chromium, common.gypi. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
brettw, Dan Beam
CC:
chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gut gyp_chromium, common.gypi. This change removes all of the code referencing gyp_chromium that isn't needed to keep the closure_compilation builder working and/or also needed for proper functioning of the gclient hooks. R=brettw@chromium.org, dbeam@chromium.org BUG=570091, 632206 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0730244c01fd8639fbebd6985d06fb64dac4c9fe Cr-Commit-Position: refs/heads/master@{#420182}

Patch Set 1 #

Patch Set 2 : turn off circular check, clean up a bit #

Patch Set 3 : merge #

Patch Set 4 : linting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7265 lines) Patch
D build/PRESUBMIT.py View 1 chunk +0 lines, -16 lines 0 comments Download
M build/common.gypi View 1 2 1 chunk +2 lines, -6315 lines 0 comments Download
M build/gyp_chromium.py View 1 2 3 4 chunks +13 lines, -306 lines 0 comments Download
D build/gyp_chromium_test.py View 1 chunk +0 lines, -64 lines 0 comments Download
M docs/ccache_mac.md View 1 chunk +0 lines, -26 lines 0 comments Download
M docs/profiling_content_shell_on_android.md View 2 chunks +0 lines, -8 lines 0 comments Download
D tools/gn/bin/gyp_flag_compare.py View 1 chunk +0 lines, -411 lines 0 comments Download
D tools/gyp-explain.py View 1 chunk +0 lines, -119 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Dirk Pranke
4 years, 3 months ago (2016-09-20 00:23:48 UTC) #1
Dan Beam
this looks familiar! https://codereview.chromium.org/2345653002/diff/20001/build/common.gypi anyways, lgtm from a closure point-of-view unfortunately we'll only really know ...
4 years, 3 months ago (2016-09-20 00:40:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355673003/60001
4 years, 3 months ago (2016-09-21 21:24:04 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-21 22:27:48 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 22:29:23 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0730244c01fd8639fbebd6985d06fb64dac4c9fe
Cr-Commit-Position: refs/heads/master@{#420182}

Powered by Google App Engine
This is Rietveld 408576698