docs/profiling_content_shell_on_android.md - Issue 2355673003: Gut gyp_chromium, common.gypi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: docs/profiling_content_shell_on_android.md

Issue 2355673003: Gut gyp_chromium, common.gypi. (Closed)

Patch Set: linting Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: docs/profiling_content_shell_on_android.md

diff --git a/docs/profiling_content_shell_on_android.md b/docs/profiling_content_shell_on_android.md

index 3243ab3b5e3ce6166ec473389043318b33ed269b..e954b6cb4e8ad611939d7ea50883f7911f372056 100644

--- a/docs/profiling_content_shell_on_android.md

+++ b/docs/profiling_content_shell_on_android.md

@@ -77,12 +77,6 @@ http://androidmuscle.com/how-to-enable-usb-debugging-developer-options-on-nexus-

Rebuild `content_shell_apk` with profiling enabled.

-With GYP (deprecated):

- export GYP_DEFINES="$GYP_DEFINES profiling=1"

- build/gyp_chromium

- ninja -C out/Release content_shell_apk

With GN:

gn args out/Profiling

@@ -197,8 +191,6 @@ Run the following:

1. If you don’t see chromium/webkit symbols, make sure that you built/pushed

Release, and that the symlink you created to the .so is valid!

-1. If you have symbols, but your callstacks are nonsense, make sure you ran

- `build/gyp_chromium` after setting `profiling=1`, and rebuilt.

## Add symbols for the kernel

« no previous file with comments | « docs/ccache_mac.md ('k') | tools/gn/bin/gyp_flag_compare.py » ('j') | no next file with comments »