Remove ability to switch to pre-MD UI from about:flags.

Remove ability to switch to pre-MD UI from about:flags.

Remove this flag now so that people who are using it don't get weird/
broken UI as we remove pre-MD code little by little.

The flag remains to allow toggling between normal and hybrid. The user-
facing strings are rephrased as "normal" and "touch" with no mention of
Material Design. Internal nomenclature is left alone.

BUG=648281
Committed: https://crrev.com/55703dc355aea777f1ed3707d456c55f8e99bd4e
Cr-Commit-Position: refs/heads/master@{#419825}

[Evan Stade, 2016-09-19 16:14:56]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org, tdanderson@chromium.org

[Evan Stade, 2016-09-19 16:15:01]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 16:15:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 16:29:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 16:29:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdanderson, 2016-09-19 18:03:00]

lgtm with one suggestion.

https://chromiumcodereview.appspot.com/2355513002/diff/1/chrome/app/generated...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/2355513002/diff/1/chrome/app/generated...
chrome/app/generated_resources.grd:5342: +        Toggles between normal and
touch (formerly "hybrid") layouts.
I think we should keep the naming as "hybrid" here. The ultimate goal will be to
either a) completely remove the ability to manually toggle between
normal/hybrid, or b) make the normal/hybrid a permanent user-facing toggle, in
which case it should not live in about:flags.

[Evan Stade, 2016-09-19 19:25:43]

https://chromiumcodereview.appspot.com/2355513002/diff/1/chrome/app/generated...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/2355513002/diff/1/chrome/app/generated...
chrome/app/generated_resources.grd:5342: +        Toggles between normal and
touch (formerly "hybrid") layouts.
On 2016/09/19 18:03:00, tdanderson wrote:
> I think we should keep the naming as "hybrid" here. The ultimate goal will be
to
> either a) completely remove the ability to manually toggle between
> normal/hybrid, or b) make the normal/hybrid a permanent user-facing toggle, in
> which case it should not live in about:flags.

I agree that this probably shouldn't live here forever. Why does that imply we
should keep the name as "hybrid"? If we did make it a user-facing toggle, it
wouldn't be called "hybrid" would it? The main reason to leave it here for now
is that PMs, designers, QA, etc can flip it for testing purposes. Doesn't it
make more sense from their perspective to call this "touch optimized"?

[Evan Stade, 2016-09-19 19:37:43]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:38:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2016-09-19 20:09:45]

https://chromiumcodereview.appspot.com/2355513002/diff/1/chrome/app/generated...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/2355513002/diff/1/chrome/app/generated...
chrome/app/generated_resources.grd:5342: +        Toggles between normal and
touch (formerly "hybrid") layouts.
On 2016/09/19 19:25:43, Evan Stade wrote:
> On 2016/09/19 18:03:00, tdanderson wrote:
> > I think we should keep the naming as "hybrid" here. The ultimate goal will
be
> to
> > either a) completely remove the ability to manually toggle between
> > normal/hybrid, or b) make the normal/hybrid a permanent user-facing toggle,
in
> > which case it should not live in about:flags.
> 
> I agree that this probably shouldn't live here forever. Why does that imply we
> should keep the name as "hybrid"? If we did make it a user-facing toggle, it
> wouldn't be called "hybrid" would it? The main reason to leave it here for now
> is that PMs, designers, QA, etc can flip it for testing purposes. Doesn't it
> make more sense from their perspective to call this "touch optimized"?

I thought there was some higher-level plan to use "hybrid" to mean something
more than touch-optimized. Anyway I just spoke with Sebastien and renaming
this is fine by him, I'm good with it too.

[Evan Stade, 2016-09-19 20:27:46]

On 2016/09/19 20:09:45, tdanderson wrote:
>
https://chromiumcodereview.appspot.com/2355513002/diff/1/chrome/app/generated...
> File chrome/app/generated_resources.grd (right):
> 
>
https://chromiumcodereview.appspot.com/2355513002/diff/1/chrome/app/generated...
> chrome/app/generated_resources.grd:5342: +        Toggles between normal and
> touch (formerly "hybrid") layouts.
> On 2016/09/19 19:25:43, Evan Stade wrote:
> > On 2016/09/19 18:03:00, tdanderson wrote:
> > > I think we should keep the naming as "hybrid" here. The ultimate goal will
> be
> > to
> > > either a) completely remove the ability to manually toggle between
> > > normal/hybrid, or b) make the normal/hybrid a permanent user-facing
toggle,
> in
> > > which case it should not live in about:flags.
> > 
> > I agree that this probably shouldn't live here forever. Why does that imply
we
> > should keep the name as "hybrid"? If we did make it a user-facing toggle, it
> > wouldn't be called "hybrid" would it? The main reason to leave it here for
now
> > is that PMs, designers, QA, etc can flip it for testing purposes. Doesn't it
> > make more sense from their perspective to call this "touch optimized"?
> 
> I thought there was some higher-level plan to use "hybrid" to mean something
> more than touch-optimized. Anyway I just spoke with Sebastien and renaming
> this is fine by him, I'm good with it too.

thanks for asking

[commit-bot: I haz the power, 2016-09-19 20:34:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:34:14]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-09-20 01:45:29]

lgtm

[Evan Stade, 2016-09-20 14:13:19]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-09-20 14:13:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2355513002/#ps20001
(title: "some fixes")

[commit-bot: I haz the power, 2016-09-20 14:13:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 14:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 14:21:07]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2016-09-20 15:48:12]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-09-20 15:48:14]

+sky for owners review of:
    chrome/browser/extensions/extension_action_icon_factory_unittest.cc
    chrome/browser/ui/layout_constants.h
    chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc

[sky, 2016-09-20 16:57:06]

LGTM

[Evan Stade, 2016-09-20 18:32:38]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-09-20 18:32:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 18:38:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 18:40:50]

Description was changed from

==========
Remove ability to switch to pre-MD UI from about:flags.

Remove this flag now so that people who are using it don't get weird/
broken UI as we remove pre-MD code little by little.

The flag remains to allow toggling between normal and hybrid. The user-
facing strings are rephrased as "normal" and "touch" with no mention of
Material Design. Internal nomenclature is left alone.

BUG=648281
==========

to

==========
Remove ability to switch to pre-MD UI from about:flags.

Remove this flag now so that people who are using it don't get weird/
broken UI as we remove pre-MD code little by little.

The flag remains to allow toggling between normal and hybrid. The user-
facing strings are rephrased as "normal" and "touch" with no mention of
Material Design. Internal nomenclature is left alone.

BUG=648281

Committed: https://crrev.com/55703dc355aea777f1ed3707d456c55f8e99bd4e
Cr-Commit-Position: refs/heads/master@{#419825}
==========

[commit-bot: I haz the power, 2016-09-20 18:40:51]

Patchset 2 (id:??) landed as
https://crrev.com/55703dc355aea777f1ed3707d456c55f8e99bd4e
Cr-Commit-Position: refs/heads/master@{#419825}