Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2355473002: availableLogicalHeightUsing needs to take flexbox stretched heights into account (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

availableLogicalHeightUsing needs to take flexbox stretched heights into account This function is used to calculate percentage positions for relative- positioned boxes in LayoutBoxModelObject::relativePositionOffset and thus needs to check childLogicalHeightForPercentageResolution. BUG=646397 R=eae@chromium.org,dgrogan@chromium.org Review-Url: https://codereview.chromium.org/2349803002 Cr-Commit-Position: refs/heads/master@{#419271} (cherry picked from commit 95c34ae1ef40f8aff3f8c718dcdbdeb65d8431ae) Committed: https://chromium.googlesource.com/chromium/src/+/b24eb40e25e1aa31444c99b2915cd9eea641d71d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/relpos-with-percentage-top.html View 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
cbiesinger
Committed patchset #1 (id:1) manually as b24eb40e25e1aa31444c99b2915cd9eea641d71d.
4 years, 3 months ago (2016-09-19 15:02:20 UTC) #2
eae
4 years, 3 months ago (2016-09-19 16:21:27 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698