Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 2349803002: availableLogicalHeightUsing needs to take flexbox stretched heights into account (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

availableLogicalHeightUsing needs to take flexbox stretched heights into account This function is used to calculate percentage positions for relative- positioned boxes in LayoutBoxModelObject::relativePositionOffset and thus needs to check childLogicalHeightForPercentageResolution. BUG=646397 R=eae@chromium.org,dgrogan@chromium.org Committed: https://crrev.com/95c34ae1ef40f8aff3f8c718dcdbdeb65d8431ae Cr-Commit-Position: refs/heads/master@{#419271}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/relpos-with-percentage-top.html View 1 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
cbiesinger
4 years, 3 months ago (2016-09-16 18:51:34 UTC) #1
eae
The percents, they're everywhere. I wonder if there is a better way to find all ...
4 years, 3 months ago (2016-09-16 19:18:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349803002/20001
4 years, 3 months ago (2016-09-16 19:23:34 UTC) #9
cbiesinger
LayoutNG will save us, I hope!
4 years, 3 months ago (2016-09-16 19:23:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 20:31:24 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 20:33:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95c34ae1ef40f8aff3f8c718dcdbdeb65d8431ae
Cr-Commit-Position: refs/heads/master@{#419271}

Powered by Google App Engine
This is Rietveld 408576698