[PaymentReqeust] Add error message in PaymentDetails. (in blink side)

[PaymentReqeust] Add error message in PaymentDetails. (in blink side)

When the payment request is updated using updateWith,
the PaymentDetails can contain a message in the error field
that will be displayed to the user.

https://w3c.github.io/browser-payment-api/#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/pull/257

BUG=648240
Committed: https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2
Cr-Commit-Position: refs/heads/master@{#421189}

[Hwanseung Lee, 2016-09-20 14:22:00]

Description was changed from

==========
[PaymentReqeust] Add error message in PaymentDetails. (in blink side)

When the payment request is updated using updateWith,
the PaymentDetails can contain a message in the error field
that will be displayed to the user.

https://w3c.github.io/browser-payment-api/#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/pull/257

BUG=648240
==========

to

==========
[PaymentReqeust] Add error message in PaymentDetails. (in blink side)

When the payment request is updated using updateWith,
the PaymentDetails can contain a message in the error field
that will be displayed to the user.

https://w3c.github.io/browser-payment-api/#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/pull/257

BUG=648240
==========

[Hwanseung Lee, 2016-09-20 14:22:01]

hs1217.lee@samsung.com changed reviewers:
+ jinho.bang@samsung.com, rouslan@chromium.org

[Hwanseung Lee, 2016-09-20 14:23:54]

@rouslan, zino
Please take a look. thank you.

[haraken, 2016-09-20 14:46:52]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-09-20 14:46:53]

Just a drive-by

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:131: output->error
= WTF::String("");

WTF::emptyString() ?

[please use gerrit instead, 2016-09-20 15:01:59]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:02:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2016-09-20 15:08:44]

@haraken.

i fixed it.

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:131: output->error
= WTF::String("");
On 2016/09/20 14:46:53, haraken wrote:
> 
> WTF::emptyString() ?

it is my intention. thank you.

[please use gerrit instead, 2016-09-20 15:40:51]

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:528:
exceptionState.throwTypeError("must be Error value  empty");
"Error value should be empty"

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp (right):

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp:62:
PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(),
buildPaymentDetailsErrorMsgForTest("Error message is not empty."),
scope.getExceptionState());
"This is an error message."

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp:405:
TEST(PaymentRequestTest, havingErrorMsgFromPaymentDetailsUpdate)
Better name for the test is "NoExceptionWithErrorMessageInUpdate".

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp:417:
request->onUpdatePaymentDetails(ScriptValue::from(scope.getScriptState(),
fromJSONString(scope.getScriptState(), "{}", scope.getExceptionState())));
Replace "{}" with detailWithErrorMsg.

[Hwanseung Lee, 2016-09-20 16:01:10]

@rouslan

i fixed it. could you review again? thank you.

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:528:
exceptionState.throwTypeError("must be Error value  empty");
On 2016/09/20 15:40:50, rouslan (slow) wrote:
> "Error value should be empty"

Done.

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp (right):

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp:62:
PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(),
buildPaymentDetailsErrorMsgForTest("Error message is not empty."),
scope.getExceptionState());
On 2016/09/20 15:40:50, rouslan (slow) wrote:
> "This is an error message."

Done.

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp:405:
TEST(PaymentRequestTest, havingErrorMsgFromPaymentDetailsUpdate)
On 2016/09/20 15:40:50, rouslan (slow) wrote:
> Better name for the test is "NoExceptionWithErrorMessageInUpdate".

Done.

https://codereview.chromium.org/2355463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp:417:
request->onUpdatePaymentDetails(ScriptValue::from(scope.getScriptState(),
fromJSONString(scope.getScriptState(), "{}", scope.getExceptionState())));
On 2016/09/20 15:40:50, rouslan (slow) wrote:
> Replace "{}" with detailWithErrorMsg.

Done.

[please use gerrit instead, 2016-09-23 11:39:01]

https://codereview.chromium.org/2355463002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2355463002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:310: }
Please also validate the length of the error message. Let's limit it to at most
2048 characters.

[Hwanseung Lee, 2016-09-23 14:38:08]

On 2016/09/23 11:39:01, rouslan (OOO 9.23-10.10) wrote:
>
https://codereview.chromium.org/2355463002/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):
> 
>
https://codereview.chromium.org/2355463002/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:310: }
> Please also validate the length of the error message. Let's limit it to at
most
> 2048 characters.

@rouslan
PTAL, i added some code to validate the length of the error message.
thank you.

[please use gerrit instead, 2016-09-27 11:05:06]

lgtm

[Hwanseung Lee, 2016-09-27 11:05:33]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-09-27 11:05:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 11:14:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 11:14:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hwanseung Lee, 2016-09-27 11:22:26]

hs1217.lee@samsung.com changed reviewers:
+ rsesek@chromium.org

[Hwanseung Lee, 2016-09-27 11:26:40]

+ rsesek@ for payment_request.mojom.
PTAL. thank you.

[Robert Sesek, 2016-09-27 13:23:03]

LGTM

[Hwanseung Lee, 2016-09-27 13:23:40]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-09-27 13:23:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 13:29:10]

Description was changed from

==========
[PaymentReqeust] Add error message in PaymentDetails. (in blink side)

When the payment request is updated using updateWith,
the PaymentDetails can contain a message in the error field
that will be displayed to the user.

https://w3c.github.io/browser-payment-api/#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/pull/257

BUG=648240
==========

to

==========
[PaymentReqeust] Add error message in PaymentDetails. (in blink side)

When the payment request is updated using updateWith,
the PaymentDetails can contain a message in the error field
that will be displayed to the user.

https://w3c.github.io/browser-payment-api/#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/pull/257

BUG=648240
==========

[commit-bot: I haz the power, 2016-09-27 13:29:11]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-27 13:31:27]

Description was changed from

==========
[PaymentReqeust] Add error message in PaymentDetails. (in blink side)

When the payment request is updated using updateWith,
the PaymentDetails can contain a message in the error field
that will be displayed to the user.

https://w3c.github.io/browser-payment-api/#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/pull/257

BUG=648240
==========

to

==========
[PaymentReqeust] Add error message in PaymentDetails. (in blink side)

When the payment request is updated using updateWith,
the PaymentDetails can contain a message in the error field
that will be displayed to the user.

https://w3c.github.io/browser-payment-api/#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/pull/257

BUG=648240

Committed: https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2
Cr-Commit-Position: refs/heads/master@{#421189}
==========

[commit-bot: I haz the power, 2016-09-27 13:31:28]

Patchset 7 (id:??) landed as
https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2
Cr-Commit-Position: refs/heads/master@{#421189}