[PaymentReqeust] Add error message in PaymentDetails. (in blink side)

third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequest.h"
 
 #include "bindings/core/v8/JSONValuesForV8.h"
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
@@ skipping 17 matching lines @@
 
 TEST(PaymentRequestTest, NoExceptionWithValidData)
 {
     V8TestingScope scope;
     makePaymentRequestOriginSecure(scope.document());
     PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), scope.getExceptionState());
 
     EXPECT_FALSE(scope.getExceptionState().hadException());
 }
 
-
 TEST(PaymentRequestTest, SupportedMethodListRequired)
 {
     V8TestingScope scope;
     makePaymentRequestOriginSecure(scope.document());
     PaymentRequest::create(scope.getScriptState(), HeapVector<PaymentMethodData>(), buildPaymentDetailsForTest(), scope.getExceptionState());
 
     EXPECT_TRUE(scope.getExceptionState().hadException());
     EXPECT_EQ(V8TypeError, scope.getExceptionState().code());
 }
 
 TEST(PaymentRequestTest, TotalRequired)
 {
     V8TestingScope scope;
     makePaymentRequestOriginSecure(scope.document());
     PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), PaymentDetails(), scope.getExceptionState());
 
     EXPECT_TRUE(scope.getExceptionState().hadException());
     EXPECT_EQ(V8TypeError, scope.getExceptionState().code());
 }
 
+TEST(PaymentRequestTest, ErrorMsgMustBeEmptyInConstrctor)
+{
+    V8TestingScope scope;
+    makePaymentRequestOriginSecure(scope.document());
+    PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsErrorMsgForTest("Error message is not empty."), scope.getExceptionState());

[please use gerrit instead, 2016/09/20 15:40:50]

"This is an error message."

[Hwanseung Lee, 2016/09/20 16:01:09]

Done.

+
+    EXPECT_TRUE(scope.getExceptionState().hadException());
+    EXPECT_EQ(V8TypeError, scope.getExceptionState().code());
+}
+
 TEST(PaymentRequestTest, NullShippingOptionWhenNoOptionsAvailable)
 {
     V8TestingScope scope;
     makePaymentRequestOriginSecure(scope.document());
     PaymentDetails details;
     details.setTotal(buildPaymentItemForTest());
     PaymentOptions options;
     options.setRequestShipping(true);
 
     PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), details, options, scope.getExceptionState());
@@ skipping 317 matching lines @@
     String detail = "{\"total\": {\"label\": \"Total\", \"amount\": {\"currency\": \"USD\", \"value\": \"5.00\"}},"
         "\"shippingOptions\": [{\"id\": \"slow\", \"label\": \"Slow\", \"amount\": {\"currency\": \"USD\", \"value\": \"5.00\"}},"
         "{\"id\": \"fast\", \"label\": \"Fast\", \"amount\": {\"currency\": \"USD\", \"value\": \"50.00\"}, \"selected\": true}]}";
 
     request->onUpdatePaymentDetails(ScriptValue::from(scope.getScriptState(), fromJSONString(scope.getScriptState(), detail, scope.getExceptionState())));
     EXPECT_FALSE(scope.getExceptionState().hadException());
 
     EXPECT_EQ("fast", request->shippingOption());
 }
 
+TEST(PaymentRequestTest, havingErrorMsgFromPaymentDetailsUpdate)

[please use gerrit instead, 2016/09/20 15:40:50]

Better name for the test is "NoExceptionWithErrorMessageInUpdate".

[Hwanseung Lee, 2016/09/20 16:01:09]

Done.

+{
+    V8TestingScope scope;
+    PaymentRequestMockFunctionScope funcs(scope.getScriptState());
+    makePaymentRequestOriginSecure(scope.document());
+    PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), scope.getExceptionState());
+    EXPECT_FALSE(scope.getExceptionState().hadException());
+
+    request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
+    String detailWithErrorMsg = "{\"total\": {\"label\": \"Total\", \"amount\": {\"currency\": \"USD\", \"value\": \"5.00\"}},"
+        "\"error\": \"havingErrorMsg\"}";
+
+    request->onUpdatePaymentDetails(ScriptValue::from(scope.getScriptState(), fromJSONString(scope.getScriptState(), "{}", scope.getExceptionState())));

[please use gerrit instead, 2016/09/20 15:40:50]

Replace "{}" with detailWithErrorMsg.

[Hwanseung Lee, 2016/09/20 16:01:09]

Done.

+    EXPECT_FALSE(scope.getExceptionState().hadException());
+}
+
 } // namespace
 } // namespace blink