macviews: use system text selection color

macviews: use system text selection color

There's a user preference for the text selection color, which we should honor
even in Harmony. If it looks weird that's up to the user.

BUG=647521
Committed: https://crrev.com/ccc35e674e1e15fd87bfc994b470e4c283df62c4
Cr-Commit-Position: refs/heads/master@{#419723}

[Elly Fong-Jones, 2016-09-19 13:25:59]

Description was changed from

==========
macviews: use system text selection color

There's a user preference for the text selection color, which we should honor
even in Harmony. If it looks weird that's up to the user.

BUG=647521
==========

to

==========
macviews: use system text selection color

There's a user preference for the text selection color, which we should honor
even in Harmony. If it looks weird that's up to the user.

BUG=647521
==========

[Elly Fong-Jones, 2016-09-19 13:26:00]

ellyjones@chromium.org changed reviewers:
+ estade@chromium.org, sky@chromium.org

[Elly Fong-Jones, 2016-09-19 13:26:07]

estade, sky: ptal? :)

[sky, 2016-09-19 15:12:23]

LGTM

[Evan Stade, 2016-09-19 16:03:49]

one question, otherwise rubber stamp lgtm

https://codereview.chromium.org/2355433002/diff/1/ui/native_theme/native_them...
File ui/native_theme/native_theme_mac.mm (right):

https://codereview.chromium.org/2355433002/diff/1/ui/native_theme/native_them...
ui/native_theme/native_theme_mac.mm:159: case
kColorId_TextfieldSelectionBackgroundFocused:
Is it not possible to change other textfield colors, like
kColorId_TextfieldSelectionColor?

[Elly Fong-Jones, 2016-09-20 11:48:00]

On 2016/09/19 16:03:49, Evan Stade wrote:
> one question, otherwise rubber stamp lgtm
> 
>
https://codereview.chromium.org/2355433002/diff/1/ui/native_theme/native_them...
> File ui/native_theme/native_theme_mac.mm (right):
> 
>
https://codereview.chromium.org/2355433002/diff/1/ui/native_theme/native_them...
> ui/native_theme/native_theme_mac.mm:159: case
> kColorId_TextfieldSelectionBackgroundFocused:
> Is it not possible to change other textfield colors, like
> kColorId_TextfieldSelectionColor?

Oddly enough, yes. You can only set TextfieldSelectionBackgroundFocused in the
system UI. Go figure.

[Elly Fong-Jones, 2016-09-20 11:48:07]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-20 11:48:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 12:24:33]

Description was changed from

==========
macviews: use system text selection color

There's a user preference for the text selection color, which we should honor
even in Harmony. If it looks weird that's up to the user.

BUG=647521
==========

to

==========
macviews: use system text selection color

There's a user preference for the text selection color, which we should honor
even in Harmony. If it looks weird that's up to the user.

BUG=647521
==========

[commit-bot: I haz the power, 2016-09-20 12:24:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 12:26:59]

Description was changed from

==========
macviews: use system text selection color

There's a user preference for the text selection color, which we should honor
even in Harmony. If it looks weird that's up to the user.

BUG=647521
==========

to

==========
macviews: use system text selection color

There's a user preference for the text selection color, which we should honor
even in Harmony. If it looks weird that's up to the user.

BUG=647521

Committed: https://crrev.com/ccc35e674e1e15fd87bfc994b470e4c283df62c4
Cr-Commit-Position: refs/heads/master@{#419723}
==========

[commit-bot: I haz the power, 2016-09-20 12:27:00]

Patchset 1 (id:??) landed as
https://crrev.com/ccc35e674e1e15fd87bfc994b470e4c283df62c4
Cr-Commit-Position: refs/heads/master@{#419723}