Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2355433002: macviews: use system text selection color (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

macviews: use system text selection color There's a user preference for the text selection color, which we should honor even in Harmony. If it looks weird that's up to the user. BUG=647521 Committed: https://crrev.com/ccc35e674e1e15fd87bfc994b470e4c283df62c4 Cr-Commit-Position: refs/heads/master@{#419723}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M ui/native_theme/native_theme_mac.mm View 3 chunks +10 lines, -3 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
Elly Fong-Jones
estade, sky: ptal? :)
4 years, 3 months ago (2016-09-19 13:26:07 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-09-19 15:12:23 UTC) #4
Evan Stade
one question, otherwise rubber stamp lgtm https://codereview.chromium.org/2355433002/diff/1/ui/native_theme/native_theme_mac.mm File ui/native_theme/native_theme_mac.mm (right): https://codereview.chromium.org/2355433002/diff/1/ui/native_theme/native_theme_mac.mm#newcode159 ui/native_theme/native_theme_mac.mm:159: case kColorId_TextfieldSelectionBackgroundFocused: Is ...
4 years, 3 months ago (2016-09-19 16:03:49 UTC) #5
Elly Fong-Jones
On 2016/09/19 16:03:49, Evan Stade wrote: > one question, otherwise rubber stamp lgtm > > ...
4 years, 3 months ago (2016-09-20 11:48:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355433002/1
4 years, 3 months ago (2016-09-20 11:48:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 12:24:34 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 12:27:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccc35e674e1e15fd87bfc994b470e4c283df62c4
Cr-Commit-Position: refs/heads/master@{#419723}

Powered by Google App Engine
This is Rietveld 408576698