macviews: use system text selection color

ui/native_theme/native_theme_mac.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/native_theme/native_theme_mac.h"
 
 #import <Cocoa/Cocoa.h>
 #include <stddef.h>
 
 #include "base/mac/mac_util.h"
@@ skipping 109 matching lines @@
 
 // static
 SkColor NativeThemeMac::ApplySystemControlTint(SkColor color) {
   if ([NSColor currentControlTint] == NSGraphiteControlTint)
     return ColorToGrayscale(color);
   return color;
 }
 
 SkColor NativeThemeMac::GetSystemColor(ColorId color_id) const {
   // Even with --secondary-ui-md, menus use the platform colors and styling, and
-  // Mac has a couple of specific color overrides.
+  // Mac has a couple of specific color overrides, documented below.
   switch (color_id) {
     case kColorId_EnabledMenuItemForegroundColor:
       return NSSystemColorToSkColor([NSColor controlTextColor]);
     case kColorId_DisabledMenuItemForegroundColor:
     case kColorId_DisabledEmphasizedMenuItemForegroundColor:
       return NSSystemColorToSkColor([NSColor disabledControlTextColor]);
     case kColorId_SelectedMenuItemForegroundColor:
       return NSSystemColorToSkColor([NSColor selectedMenuItemTextColor]);
     case kColorId_FocusedMenuItemBackgroundColor:
     case kColorId_HoverMenuItemBackgroundColor:
       return NSSystemColorToSkColor([NSColor selectedMenuItemColor]);
     case kColorId_MenuBackgroundColor:
       return kMenuPopupBackgroundColor;
     case kColorId_MenuSeparatorColor:
       return base::mac::IsOS10_9() ? kMenuSeparatorColorMavericks
                                    : kMenuSeparatorColor;
     case kColorId_MenuBorderColor:
       return kMenuBorderColor;
 
+    // Mac has a different "pressed button" styling because it doesn't use
+    // ripples.
     case kColorId_ButtonPressedShade:
       return SkColorSetA(SK_ColorBLACK, 0x08);
+
+    // There's a system setting General > Highlight color which sets the
+    // background color for text selections. We honor that setting.
+    // TODO(ellyjones): Listen for NSSystemColorsDidChangeNotification somewhere
+    // and propagate it to the View hierarchy.
+    case kColorId_TextfieldSelectionBackgroundFocused:

[Evan Stade, 2016/09/19 16:03:49]

Is it not possible to change other textfield colors, like
kColorId_TextfieldSelectionColor?

+      return NSSystemColorToSkColor([NSColor selectedTextBackgroundColor]);
     default:
       break;
   }
 
   if (ui::MaterialDesignController::IsSecondaryUiMaterial())
     return ApplySystemControlTint(GetAuraColor(color_id, this));
 
   // TODO(tapted): Add caching for these, and listen for
   // NSSystemColorsDidChangeNotification.
   switch (color_id) {
@@ skipping 43 matching lines @@
 
     // Text fields.
     case kColorId_TextfieldDefaultColor:
     case kColorId_TextfieldReadOnlyColor:
       return NSSystemColorToSkColor([NSColor textColor]);
     case kColorId_TextfieldDefaultBackground:
     case kColorId_TextfieldReadOnlyBackground:
       return NSSystemColorToSkColor([NSColor textBackgroundColor]);
     case kColorId_TextfieldSelectionColor:
       return NSSystemColorToSkColor([NSColor selectedTextColor]);
-    case kColorId_TextfieldSelectionBackgroundFocused:
-      return NSSystemColorToSkColor([NSColor selectedTextBackgroundColor]);
 
     // Trees/Tables. For focused text, use the alternate* versions, which
     // NSColor documents as "the table and list view equivalent to the
     // selectedControlTextColor".
     case kColorId_TreeBackground:
     case kColorId_TableBackground:
       return NSSystemColorToSkColor([NSColor controlBackgroundColor]);
     case kColorId_TreeText:
     case kColorId_TableText:
     case kColorId_TableSelectedTextUnfocused:
@@ skipping 202 matching lines @@
   canvas->drawDRRect(outer_shape, shape, paint);
 }
 
 NativeThemeMac::NativeThemeMac() {
 }
 
 NativeThemeMac::~NativeThemeMac() {
 }
 
 }  // namespace ui