Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 2355253002: [turbofan] Eliminate usage of representation dimension of Type. (Closed)

Created:
4 years, 3 months ago by mvstanton
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Eliminate uses of representation dimension of Type. BUG= Committed: https://crrev.com/e13a825b6ea3c247d9acd41373527866b3cde502 Cr-Commit-Position: refs/heads/master@{#39621}

Patch Set 1 #

Patch Set 2 : Updates. #

Patch Set 3 : Addressed commented out test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M src/compiler/access-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/access-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-create-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/representation-change.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 2 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mvstanton
Hi Benedikt, can you have a look at this? I'm addressing the commented out test ...
4 years, 3 months ago (2016-09-22 09:03:36 UTC) #3
Benedikt Meurer
Nice. LGTM.
4 years, 3 months ago (2016-09-22 09:28:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355253002/40001
4 years, 3 months ago (2016-09-22 09:56:38 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 10:33:06 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 10:33:30 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e13a825b6ea3c247d9acd41373527866b3cde502
Cr-Commit-Position: refs/heads/master@{#39621}

Powered by Google App Engine
This is Rietveld 408576698