src/compiler/access-info.cc - Issue 2355253002: [turbofan] Eliminate usage of representation dimension of Type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/access-info.cc

Issue 2355253002: [turbofan] Eliminate usage of representation dimension of Type. (Closed)

Patch Set: Addressed commented out test. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/access-info.cc

diff --git a/src/compiler/access-info.cc b/src/compiler/access-info.cc

index aa0055a950cac6d36adae113ace5f9f6234b1ae3..329cb93fe523baa2f5dd404623d93a8d6269b2ae 100644

--- a/src/compiler/access-info.cc

+++ b/src/compiler/access-info.cc

@@ -437,7 +437,7 @@ bool AccessInfoFactory::LookupSpecialFieldAccessor(

int offset;

if (Accessors::IsJSObjectFieldAccessor(map, name, &offset)) {

FieldIndex field_index = FieldIndex::ForInObjectOffset(offset);

- Type* field_type = Type::Tagged();

+ Type* field_type = Type::NonInternal();

MachineRepresentation field_representation = MachineRepresentation::kTagged;

if (map->IsStringMap()) {

DCHECK(Name::Equals(factory()->length_string(), name));

« no previous file with comments | « src/compiler/access-builder.cc ('k') | src/compiler/js-create-lowering.cc » ('j') | no next file with comments »