Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: media/video/capture/video_capture_device.h

Issue 23551011: From Video Capture, abolish OnFrameInfo and enable resolution changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add assert to vcbp unittest Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/capture/video_capture_device.h
diff --git a/media/video/capture/video_capture_device.h b/media/video/capture/video_capture_device.h
index bc145ff6c7c2fb2ced7aaab046f97b34933f6ca7..0e7af7f36d674768a0ddadb64e94e0851769f3f9 100644
--- a/media/video/capture/video_capture_device.h
+++ b/media/video/capture/video_capture_device.h
@@ -125,16 +125,17 @@ class MEDIA_EXPORT VideoCaptureDevice {
// Reserve an output buffer into which a video frame can be captured
// directly. If all buffers are currently busy, returns NULL.
//
- // The returned VideoFrames will always be allocated with a YV12 format. The
- // size will match that specified by an earlier call to OnFrameInfo. It is
- // the VideoCaptureDevice's responsibility to obey whatever stride and
- // memory layout are indicated on the returned VideoFrame object.
+ // The returned VideoFrames will always be allocated with a YV12 format and
+ // have dimensions matching |size|. It is the VideoCaptureDevice's
+ // responsibility to obey whatever stride and memory layout are indicated on
+ // the returned VideoFrame object.
//
// The output buffer stays reserved for use by the calling
// VideoCaptureDevice until either the last reference to the VideoFrame is
// released, or until the buffer is passed back to the Client's
// OnIncomingCapturedFrame() method.
- virtual scoped_refptr<media::VideoFrame> ReserveOutputBuffer() = 0;
+ virtual scoped_refptr<media::VideoFrame> ReserveOutputBuffer(
+ const gfx::Size& size) = 0;
// Captured a new video frame as a raw buffer. The size, color format, and
// layout are taken from the parameters specified by an earlier call to

Powered by Google App Engine
This is Rietveld 408576698