Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: media/video/capture/video_capture.h

Issue 23551011: From Video Capture, abolish OnFrameInfo and enable resolution changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add assert to vcbp unittest Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/capture/video_capture.h
diff --git a/media/video/capture/video_capture.h b/media/video/capture/video_capture.h
index 3a4eb0e2d3271a9582ea9e8e51e348db81f77b28..e4fde1343d4687f955e69046d94757cda74d7408 100644
--- a/media/video/capture/video_capture.h
+++ b/media/video/capture/video_capture.h
@@ -48,12 +48,12 @@ class MEDIA_EXPORT VideoCapture {
// Notify client about device info.
virtual void OnDeviceInfoReceived(
VideoCapture* capture,
- const VideoCaptureParams& device_info) = 0;
+ const VideoCaptureFormat& device_info) = 0;
Ami GONE FROM CHROMIUM 2013/10/04 00:24:15 Any reason not to provide empty body for this, lik
ncarter (slow) 2013/10/16 02:08:40 Removed altogether.
// Notify client about the newly changed device info.
virtual void OnDeviceInfoChanged(
Ami GONE FROM CHROMIUM 2013/10/04 00:24:15 CL description makes me think OnDeviceInfo{Changed
ncarter (slow) 2013/10/16 02:08:40 Done.
VideoCapture* capture,
- const VideoCaptureParams& device_info) {};
+ const VideoCaptureFormat& device_info) {};
protected:
virtual ~EventHandler() {}
@@ -61,11 +61,11 @@ class MEDIA_EXPORT VideoCapture {
VideoCapture() {}
- // Request video capture to start capturing with |capability|.
+ // Request video capture to start capturing with |params|.
// Also register |handler| with video capture for event handling.
// |handler| must remain valid until it has received |OnRemoved()|.
virtual void StartCapture(EventHandler* handler,
- const VideoCaptureCapability& capability) = 0;
+ const VideoCaptureParams& params) = 0;
// Request video capture to stop capturing for client |handler|.
// |handler| must remain valid until it has received |OnRemoved()|.

Powered by Google App Engine
This is Rietveld 408576698