Give each page load metrics client its own histogram_suffixes list.

Give each page load metrics client its own histogram_suffixes list.

Initially, we tried to keep the PageLoad.Clients histogram_suffixes
short by sharing a master list between all clients. In practice,
each client uses a different subset of histograms, which leads to
many histograms with no data being listed in the UMA dashboard.
This change expands each unique client into its own
histogram_suffixes list that contains just the histograms logged
by that client.

BUG=648718
TBR=csharrison

Committed: https://crrev.com/64288f4567d757efa2330fb15df9d72f396d19a5
Cr-Commit-Position: refs/heads/master@{#420128}

[Bryan McQuade, 2016-09-20 19:40:55]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 19:41:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-09-20 19:46:59]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 19:47:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-09-20 19:52:07]

Description was changed from

==========
Give each page load metrics client its own histogram_suffixes list.

Initially, we tried to keep the PageLoad.Clients histogram_suffixes
short by sharing a master list between all clients. In practice,
each client uses a different subset of histograms, which leads to
many histograms with no data being listed in the UMA dashboard.
This change expands each unique client into its own
histogram_suffixes list that contains just the histograms logged
by that client.

BUG=
==========

to

==========
Give each page load metrics client its own histogram_suffixes list.

Initially, we tried to keep the PageLoad.Clients histogram_suffixes
short by sharing a master list between all clients. In practice,
each client uses a different subset of histograms, which leads to
many histograms with no data being listed in the UMA dashboard.
This change expands each unique client into its own
histogram_suffixes list that contains just the histograms logged
by that client.

BUG=648718
==========

[Bryan McQuade, 2016-09-20 19:54:32]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 19:54:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-09-20 19:55:20]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org, gayane@chromium.org

[Bryan McQuade, 2016-09-20 19:55:29]

PTAL, thanks!

[commit-bot: I haz the power, 2016-09-20 20:27:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 20:27:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gayane -on leave until 09-2017, 2016-09-21 17:03:26]

Thanks. This should be more clean.

I have done couple of spot checks and for example noticed that histograms with
Clients.Previews.OfflinePages are always empty. Is this something that is
expected?

[gayane -on leave until 09-2017, 2016-09-21 18:01:30]

lgtm

[Bryan McQuade, 2016-09-21 18:11:32]

Description was changed from

==========
Give each page load metrics client its own histogram_suffixes list.

Initially, we tried to keep the PageLoad.Clients histogram_suffixes
short by sharing a master list between all clients. In practice,
each client uses a different subset of histograms, which leads to
many histograms with no data being listed in the UMA dashboard.
This change expands each unique client into its own
histogram_suffixes list that contains just the histograms logged
by that client.

BUG=648718
==========

to

==========
Give each page load metrics client its own histogram_suffixes list.

Initially, we tried to keep the PageLoad.Clients histogram_suffixes
short by sharing a master list between all clients. In practice,
each client uses a different subset of histograms, which leads to
many histograms with no data being listed in the UMA dashboard.
This change expands each unique client into its own
histogram_suffixes list that contains just the histograms logged
by that client.

BUG=648718
TBR=csharrison
==========

[Bryan McQuade, 2016-09-21 18:11:40]

The CQ bit was checked by bmcquade@chromium.org

[commit-bot: I haz the power, 2016-09-21 18:12:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 19:07:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-21 19:09:59]

Description was changed from

==========
Give each page load metrics client its own histogram_suffixes list.

Initially, we tried to keep the PageLoad.Clients histogram_suffixes
short by sharing a master list between all clients. In practice,
each client uses a different subset of histograms, which leads to
many histograms with no data being listed in the UMA dashboard.
This change expands each unique client into its own
histogram_suffixes list that contains just the histograms logged
by that client.

BUG=648718
TBR=csharrison
==========

to

==========
Give each page load metrics client its own histogram_suffixes list.

Initially, we tried to keep the PageLoad.Clients histogram_suffixes
short by sharing a master list between all clients. In practice,
each client uses a different subset of histograms, which leads to
many histograms with no data being listed in the UMA dashboard.
This change expands each unique client into its own
histogram_suffixes list that contains just the histograms logged
by that client.

BUG=648718
TBR=csharrison

Committed: https://crrev.com/64288f4567d757efa2330fb15df9d72f396d19a5
Cr-Commit-Position: refs/heads/master@{#420128}
==========

[commit-bot: I haz the power, 2016-09-21 19:10:00]

Patchset 3 (id:??) landed as
https://crrev.com/64288f4567d757efa2330fb15df9d72f396d19a5
Cr-Commit-Position: refs/heads/master@{#420128}