Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2355093002: Give each page load metrics client its own histogram_suffixes list. (Closed)
Patch Set: restore deprecated client names Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 495565b93568b70a3e598ee867a1b769e2b5b0c8..1142e010672903211fa7cefd0c7cbd58fabd87b9 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -104593,44 +104593,6 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="PageLoad.Timing2.NavigationToFirstBackground"/>
</histogram_suffixes>
-<histogram_suffixes name="PageLoadMetricsAbortClients" separator="."
- ordering="prefix">
- <suffix name="Clients.FromGWS2"
- label="PageLoadMetrics that are a result of a navigation from a Google
- web search">
- <obsolete>
- Deprecated in favor of Clients.FromGoogleSearch.
- </obsolete>
- </suffix>
- <suffix name="Clients.FromGoogleSearch"
- label="PageLoadMetrics that are a result of a navigation from a Google
- web search"/>
- <affected-histogram
- name="PageLoad.AbortTiming.Close.AfterCommit.BeforePaint"/>
- <affected-histogram
- name="PageLoad.AbortTiming.Close.AfterPaint.BeforeInteraction"/>
- <affected-histogram name="PageLoad.AbortTiming.Close.BeforeCommit"/>
- <affected-histogram
- name="PageLoad.AbortTiming.ForwardBackNavigation.AfterCommit.BeforePaint"/>
- <affected-histogram
- name="PageLoad.AbortTiming.ForwardBackNavigation.AfterPaint.Before1sDelayedInteraction"/>
- <affected-histogram
- name="PageLoad.AbortTiming.NewNavigation.AfterCommit.BeforePaint"/>
- <affected-histogram
- name="PageLoad.AbortTiming.NewNavigation.AfterPaint.BeforeInteraction"/>
- <affected-histogram name="PageLoad.AbortTiming.Other.BeforeCommit"/>
- <affected-histogram
- name="PageLoad.AbortTiming.Reload.AfterCommit.BeforePaint"/>
- <affected-histogram
- name="PageLoad.AbortTiming.Reload.AfterPaint.Before1sDelayedInteraction"/>
- <affected-histogram name="PageLoad.AbortTiming.Stop.AfterCommit.BeforePaint"/>
- <affected-histogram
- name="PageLoad.AbortTiming.Stop.AfterPaint.BeforeInteraction"/>
- <affected-histogram name="PageLoad.AbortTiming.Stop.BeforeCommit"/>
- <affected-histogram
- name="PageLoad.AbortTiming.UnknownNavigation.BeforeCommit"/>
-</histogram_suffixes>
-
<histogram_suffixes name="PageLoadMetricsCacheInfo" separator=".">
<suffix name="NoStore" label="Main resource had cache-control: no-store"/>
<affected-histogram
@@ -104641,11 +104603,17 @@ To add a new entry, add it with any value and run test to compute valid value.
name="PageLoad.ParseTiming.NavigationToParseStart.LoadType.ForwardBackNavigation"/>
</histogram_suffixes>
-<histogram_suffixes name="PageLoadMetricsClients" separator="."
+<histogram_suffixes name="PageLoadMetricsClientsCssScanner" separator="."
ordering="prefix">
<suffix name="Clients.CssScanner"
label="Metrics from pages scanned by the preload scanner for @import
CSS rules"/>
+ <affected-histogram
+ name="PageLoad.Experimental.PaintTiming.ParseStartToFirstMeaningfulPaint"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="PageLoadMetricsClientsDataReductionProxy"
+ separator="." ordering="prefix">
<suffix name="Clients.DataReductionProxy"
label="PageLoadMetrics that are a result of a navigation through the
data reduction proxy."/>
@@ -104653,6 +104621,23 @@ To add a new entry, add it with any value and run test to compute valid value.
label="PageLoadMetrics that are a result of a navigation through the
data reduction proxy with session in LoFi enabled or control
field trial, and when the connection was slow."/>
+ <affected-histogram
+ name="PageLoad.DocumentTiming.NavigationToDOMContentLoadedEventFired"/>
+ <affected-histogram name="PageLoad.DocumentTiming.NavigationToFirstLayout"/>
+ <affected-histogram
+ name="PageLoad.DocumentTiming.NavigationToLoadEventFired"/>
+ <affected-histogram
+ name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>
+ <affected-histogram name="PageLoad.PaintTiming.NavigationToFirstImagePaint"/>
+ <affected-histogram name="PageLoad.PaintTiming.NavigationToFirstPaint"/>
+ <affected-histogram name="PageLoad.PaintTiming.NavigationToFirstTextPaint"/>
+ <affected-histogram name="PageLoad.ParseTiming.NavigationToParseStart"/>
+ <affected-histogram name="PageLoad.ParseTiming.ParseBlockedOnScriptLoad"/>
+ <affected-histogram name="PageLoad.ParseTiming.ParseDuration"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="PageLoadMetricsClientsDocWrite" separator="."
+ ordering="prefix">
<suffix name="Clients.DocWrite.Block"
label="PageLoadMetrics from a page that has synchronous, cross-origin
document.written scripts that could be blocked if the
@@ -104660,16 +104645,37 @@ To add a new entry, add it with any value and run test to compute valid value.
<suffix name="Clients.DocWrite.Evaluator"
label="PageLoadMetrics from a page that could have been evaluated by
the DocumentWriteEvaluator"/>
+ <affected-histogram
+ name="PageLoad.Experimental.PaintTiming.ParseStartToFirstMeaningfulPaint"/>
+ <affected-histogram
+ name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>
+ <affected-histogram
+ name="PageLoad.PaintTiming.ParseStartToFirstContentfulPaint"/>
+ <affected-histogram
+ name="PageLoad.ParseTiming.ParseBlockedOnScriptExecution"/>
+ <affected-histogram
+ name="PageLoad.ParseTiming.ParseBlockedOnScriptExecutionFromDocumentWrite"/>
+ <affected-histogram name="PageLoad.ParseTiming.ParseBlockedOnScriptLoad"/>
+ <affected-histogram
+ name="PageLoad.ParseTiming.ParseBlockedOnScriptLoadFromDocumentWrite"/>
+ <affected-histogram name="PageLoad.ParseTiming.ParseDuration"/>
+ <affected-histogram name="PageLoad.Timing2.NavigationToFirstContentfulPaint"/>
+ <affected-histogram name="PageLoad.Timing2.ParseBlockedOnScriptLoad"/>
+ <affected-histogram
+ name="PageLoad.Timing2.ParseBlockedOnScriptLoad.ParseComplete"/>
+ <affected-histogram
+ name="PageLoad.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite"/>
+ <affected-histogram
+ name="PageLoad.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite.ParseComplete"/>
+ <affected-histogram name="PageLoad.Timing2.ParseDuration"/>
+ <affected-histogram name="PageLoad.Timing2.ParseStartToFirstContentfulPaint"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="PageLoadMetricsClientsFromGoogleSearch" separator="."
+ ordering="prefix">
<suffix name="Clients.FromGoogleSearch"
label="PageLoadMetrics that are a result of a navigation from a Google
web search"/>
- <suffix name="Clients.Previews.OfflinePages"
- label="PageLoadMetrics that are a result of a navigation that shows
- users an offline page preview. Offline page previews are shown
- when a user's effective connection type is prohibitively slow."/>
- <suffix name="Clients.ServiceWorker"
- label="PageLoadMetrics from a page that is controlled by a Service
- Worker"/>
<suffix name="Clients.FromGWS"
label="PageLoadMetrics that are a result of a navigation from a Google
web search">
@@ -104685,13 +104691,34 @@ To add a new entry, add it with any value and run test to compute valid value.
</obsolete>
</suffix>
<affected-histogram
+ name="PageLoad.AbortTiming.Close.AfterCommit.BeforePaint"/>
+ <affected-histogram
+ name="PageLoad.AbortTiming.Close.AfterPaint.BeforeInteraction"/>
+ <affected-histogram name="PageLoad.AbortTiming.Close.BeforeCommit"/>
+ <affected-histogram
+ name="PageLoad.AbortTiming.ForwardBackNavigation.AfterCommit.BeforePaint"/>
+ <affected-histogram
+ name="PageLoad.AbortTiming.ForwardBackNavigation.AfterPaint.Before1sDelayedInteraction"/>
+ <affected-histogram
+ name="PageLoad.AbortTiming.NewNavigation.AfterCommit.BeforePaint"/>
+ <affected-histogram
+ name="PageLoad.AbortTiming.NewNavigation.AfterPaint.BeforeInteraction"/>
+ <affected-histogram name="PageLoad.AbortTiming.Other.BeforeCommit"/>
+ <affected-histogram
+ name="PageLoad.AbortTiming.Reload.AfterCommit.BeforePaint"/>
+ <affected-histogram
+ name="PageLoad.AbortTiming.Reload.AfterPaint.Before1sDelayedInteraction"/>
+ <affected-histogram name="PageLoad.AbortTiming.Stop.AfterCommit.BeforePaint"/>
+ <affected-histogram
+ name="PageLoad.AbortTiming.Stop.AfterPaint.BeforeInteraction"/>
+ <affected-histogram name="PageLoad.AbortTiming.Stop.BeforeCommit"/>
+ <affected-histogram
+ name="PageLoad.AbortTiming.UnknownNavigation.BeforeCommit"/>
+ <affected-histogram
name="PageLoad.DocumentTiming.NavigationToDOMContentLoadedEventFired"/>
- <affected-histogram name="PageLoad.DocumentTiming.NavigationToFirstLayout"/>
<affected-histogram
name="PageLoad.DocumentTiming.NavigationToLoadEventFired"/>
<affected-histogram
- name="PageLoad.Experimental.PaintTiming.ParseStartToFirstMeaningfulPaint"/>
- <affected-histogram
name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>
<affected-histogram name="PageLoad.PaintTiming.NavigationToFirstImagePaint"/>
<affected-histogram name="PageLoad.PaintTiming.NavigationToFirstPaint"/>
@@ -104699,37 +104726,26 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram
name="PageLoad.PaintTiming.ParseStartToFirstContentfulPaint"/>
<affected-histogram name="PageLoad.ParseTiming.NavigationToParseStart"/>
- <affected-histogram
- name="PageLoad.ParseTiming.ParseBlockedOnScriptExecution"/>
- <affected-histogram
- name="PageLoad.ParseTiming.ParseBlockedOnScriptExecutionFromDocumentWrite"/>
- <affected-histogram name="PageLoad.ParseTiming.ParseBlockedOnScriptLoad"/>
- <affected-histogram
- name="PageLoad.ParseTiming.ParseBlockedOnScriptLoadFromDocumentWrite"/>
<affected-histogram name="PageLoad.ParseTiming.ParseDuration"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="PageLoadMetricsClientsOfflinePages" separator="."
+ ordering="prefix">
+ <suffix name="Clients.Previews.OfflinePages"
+ label="PageLoadMetrics that are a result of a navigation that shows
+ users an offline page preview. Offline page previews are shown
+ when a user's effective connection type is prohibitively slow."/>
<affected-histogram
- name="PageLoad.Timing2.DOMLoadingToDOMContentLoadedEventFired"/>
- <affected-histogram name="PageLoad.Timing2.DOMLoadingToFirstContentfulPaint"/>
- <affected-histogram
- name="PageLoad.Timing2.NavigationToDOMContentLoadedEventFired"/>
- <affected-histogram name="PageLoad.Timing2.NavigationToFirstContentfulPaint"/>
- <affected-histogram name="PageLoad.Timing2.NavigationToFirstImagePaint"/>
- <affected-histogram name="PageLoad.Timing2.NavigationToFirstLayout"/>
- <affected-histogram name="PageLoad.Timing2.NavigationToFirstPaint"/>
- <affected-histogram name="PageLoad.Timing2.NavigationToFirstTextPaint"/>
- <affected-histogram name="PageLoad.Timing2.NavigationToLoadEventFired"/>
- <affected-histogram name="PageLoad.Timing2.ParseBlockedOnScriptLoad"/>
- <affected-histogram
- name="PageLoad.Timing2.ParseBlockedOnScriptLoad.ParseComplete"/>
+ name="PageLoad.DocumentTiming.NavigationToDOMContentLoadedEventFired"/>
+ <affected-histogram name="PageLoad.DocumentTiming.NavigationToFirstLayout"/>
<affected-histogram
- name="PageLoad.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite"/>
+ name="PageLoad.DocumentTiming.NavigationToLoadEventFired"/>
<affected-histogram
- name="PageLoad.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite.ParseComplete"/>
- <affected-histogram name="PageLoad.Timing2.ParseDuration"/>
- <affected-histogram name="PageLoad.Timing2.ParseStartToFirstContentfulPaint"/>
+ name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>
+ <affected-histogram name="PageLoad.ParseTiming.NavigationToParseStart"/>
</histogram_suffixes>
-<histogram_suffixes name="PageLoadMetricsClients.Reload" separator="."
+<histogram_suffixes name="PageLoadMetricsClientsReload" separator="."
ordering="prefix">
<suffix name="Clients.Reload"
label="PageLoadMetrics from a page that is reloaded"/>
@@ -104737,6 +104753,39 @@ To add a new entry, add it with any value and run test to compute valid value.
name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>
</histogram_suffixes>
+<histogram_suffixes name="PageLoadMetricsClientsServiceWorker" separator="."
+ ordering="prefix">
+ <suffix name="Clients.ServiceWorker"
+ label="PageLoadMetrics from a page that is controlled by a Service
+ Worker"/>
+ <affected-histogram
+ name="PageLoad.DocumentTiming.NavigationToDOMContentLoadedEventFired"/>
+ <affected-histogram
+ name="PageLoad.DocumentTiming.NavigationToLoadEventFired"/>
+ <affected-histogram
+ name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>
+ <affected-histogram
+ name="PageLoad.PaintTiming.ParseStartToFirstContentfulPaint"/>
+ <affected-histogram name="PageLoad.Timing2.NavigationToFirstContentfulPaint">
+ <obsolete>
+ Deprecated in favor of PaintTiming equivalent.
+ </obsolete>
+ </affected-histogram>
+</histogram_suffixes>
+
+<histogram_suffixes name="PageLoadMetricsClientsServiceWorkerSpecialApps"
+ separator=".">
+ <suffix name="inbox" label="Custom histogram for Inbox"/>
+ <affected-histogram
+ name="PageLoad.Clients.ServiceWorker.DocumentTiming.NavigationToDOMContentLoadedEventFired"/>
+ <affected-histogram
+ name="PageLoad.Clients.ServiceWorker.DocumentTiming.NavigationToLoadEventFired"/>
+ <affected-histogram
+ name="PageLoad.Clients.ServiceWorker.PaintTiming.NavigationToFirstContentfulPaint"/>
+ <affected-histogram
+ name="PageLoad.Clients.ServiceWorker.PaintTiming.ParseStartToFirstContentfulPaint"/>
+</histogram_suffixes>
+
<histogram_suffixes name="PageLoadMetricsLoadType" separator=".">
<suffix name="LoadType.Reload" label="Restricted to reloaded pages."/>
<suffix name="LoadType.ForwardBackNavigation"
@@ -106052,18 +106101,6 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="ServiceWorkerCache.Scheduler.QueueLength"/>
</histogram_suffixes>
-<histogram_suffixes name="ServiceWorkerSpecialApps" separator=".">
- <suffix name="inbox" label="Custom histogram for Inbox"/>
- <affected-histogram
- name="PageLoad.Clients.ServiceWorker.DocumentTiming.NavigationToDOMContentLoadedEventFired"/>
- <affected-histogram
- name="PageLoad.Clients.ServiceWorker.DocumentTiming.NavigationToLoadEventFired"/>
- <affected-histogram
- name="PageLoad.Clients.ServiceWorker.PaintTiming.NavigationToFirstContentfulPaint"/>
- <affected-histogram
- name="PageLoad.Clients.ServiceWorker.PaintTiming.ParseStartToFirstContentfulPaint"/>
-</histogram_suffixes>
-
<histogram_suffixes name="ServiceWorkerSpecialAppsForEventDispatchingDelay"
separator=".">
<suffix name="docs" label="Custom histogram for Google Docs and Drive"/>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698