core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp - Issue 2355083002: Make CPDF_Array not do indirect object creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

Issue 2355083002: Make CPDF_Array not do indirect object creation. (Closed)

Patch Set: Missed two references Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp b/core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

index 577204336782789600f47c0ec7abc99244230a57..cbfdf2b9aca9530c2c15508dd29bd10748b6615e 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

@@ -813,7 +813,8 @@ TEST(PDFObjectTest, CloneCheckLoop) {

objects_holder.AddIndirectObject(dict_obj);

EXPECT_EQ(1u, dict_obj->GetObjNum());

dict_obj->SetFor("arr", arr_obj);

- arr_obj->InsertAt(0, dict_obj, &objects_holder);

+ arr_obj->InsertAt(

+ 0, new CPDF_Reference(&objects_holder, dict_obj->GetObjNum()));

CPDF_Object* elem0 = arr_obj->GetObjectAt(0);

ASSERT_TRUE(elem0);

ASSERT_TRUE(elem0->IsReference());