core/fpdfapi/fpdf_parser/cpdf_document.cpp - Issue 2355083002: Make CPDF_Array not do indirect object creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_document.cpp

Issue 2355083002: Make CPDF_Array not do indirect object creation. (Closed)

Patch Set: Missed two references Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_document.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_document.cpp b/core/fpdfapi/fpdf_parser/cpdf_document.cpp

index d3909ceaec2ee579f6fd9036baf4c0eaa6316c34..916d491ef1b76429bf586ba2b2af22d75b6dc980 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_document.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_document.cpp

@@ -302,7 +302,7 @@ int InsertNewPage(CPDF_Document* pDoc,

pPagesList = new CPDF_Array;

pPages->SetFor("Kids", pPagesList);

}

- pPagesList->Add(pPageDict, pDoc);

+ pPagesList->Add(new CPDF_Reference(pDoc, pPageDict->GetObjNum()));

pPages->SetIntegerFor("Count", nPages + 1);

pPageDict->SetReferenceFor("Parent", pDoc, pPages->GetObjNum());

} else {