Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2355053003: Omnibox - Allow Matching in Port Number (Closed)

Created:
4 years, 3 months ago by Mark P
Modified:
3 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox - Allow Matching in Port Number Previously the port number was misidentified as the registry (.com, .org, etc.). The registry isn't used for scoring, which means the matching the port number wouldn't be allowed. Now they're allowed. BUG=595524

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -3 lines) Patch
M components/omnibox/browser/scored_history_match.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/browser/scored_history_match.cc View 2 chunks +21 lines, -3 lines 1 comment Download
M components/omnibox/browser/scored_history_match_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Mark P
Peter, Please take a look at your leisure. thanks, mark
4 years, 3 months ago (2016-09-20 19:31:56 UTC) #3
Peter Kasting
https://codereview.chromium.org/2355053003/diff/1/components/omnibox/browser/scored_history_match.cc File components/omnibox/browser/scored_history_match.cc (right): https://codereview.chromium.org/2355053003/diff/1/components/omnibox/browser/scored_history_match.cc#newcode485 components/omnibox/browser/scored_history_match.cc:485: port_pos = std::string::npos; I'm really uncomfortable with all this ...
4 years, 3 months ago (2016-09-20 20:44:56 UTC) #4
Peter Kasting
3 years, 10 months ago (2017-02-11 01:58:54 UTC) #5
Should this be closed?

Powered by Google App Engine
This is Rietveld 408576698