Omnibox - Allow Matching in Port Number

components/omnibox/browser/scored_history_match_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/scored_history_match.h"
 
 #include <algorithm>
 #include <memory>
 
 #include "base/auto_reset.h"
@@ skipping 226 matching lines @@
   EXPECT_EQ(0, scored.raw_score);
 
   // Now allow credit for the match in the TLD.
   base::AutoReset<bool> reset(&ScoredHistoryMatch::allow_tld_matches_, true);
   ScoredHistoryMatch scored_with_tld(row, visits, ASCIIToUTF16("fed com"),
       Make2Terms("fed", "com"), two_words_no_offsets, word_starts, false,
       nullptr, now);
   EXPECT_GT(scored_with_tld.raw_score, 0);
 }
 
+TEST_F(ScoredHistoryMatchTest, ScoringPort) {
+  // Reset the topicality threshold to 0, otherwise the port matches will not
+  // score above the minimum to be returned.
+  base::AutoReset<float> reset(&ScoredHistoryMatch::topicality_threshold_, 0.0);
+
+  // We use NowFromSystemTime() because MakeURLRow uses the same function
+  // to calculate last visit time when building a row.
+  base::Time now = base::Time::NowFromSystemTime();
+
+  // The URL should be returned with a positive score for a query that includes
+  // "8000".
+  std::string url_string("http://fedcba.com:8000/");
+  GURL url(url_string);
+  history::URLRow row(MakeURLRow(url_string.c_str(), "", 8, 3, 1));
+  RowWordStarts word_starts;
+  PopulateWordStarts(row, &word_starts);
+  WordStarts one_word_no_offsets(1, 0u);
+  VisitInfoVector visits = CreateVisitInfoVector(8, 3, now);
+  ScoredHistoryMatch scored(row, visits, ASCIIToUTF16("8000"),
+                            Make1Term("8000"), one_word_no_offsets,
+                            word_starts, false, nullptr, now);
+  EXPECT_GT(scored.raw_score, 0);
+
+  // Ditto for intranet URLs.
+  url_string = "http://fedcba:8000/";
+  url = GURL(url_string);
+  row = MakeURLRow(url_string.c_str(), "", 8, 3, 1);
+  scored = ScoredHistoryMatch(row, visits, ASCIIToUTF16("8000"),
+                              Make1Term("8000"), one_word_no_offsets,
+                              word_starts, false, nullptr, now);
+  EXPECT_GT(scored.raw_score, 0);
+}
+
 TEST_F(ScoredHistoryMatchTest, ScoringScheme) {
   // We use NowFromSystemTime() because MakeURLRow uses the same function
   // to calculate last visit time when building a row.
   base::Time now = base::Time::NowFromSystemTime();
 
   // By default the URL should not be returned for a query that includes "http".
   std::string url_string("http://fedcba/");
   const GURL url(url_string);
   history::URLRow row(MakeURLRow(url_string.c_str(), "", 8, 3, 1));
   RowWordStarts word_starts;
@@ skipping 397 matching lines @@
 
   EXPECT_TRUE(
       ScoredHistoryMatch::GetHQPBucketsFromString(buckets_str, &hqp_buckets));
   EXPECT_THAT(hqp_buckets, ElementsAre(Pair(0.0, 400), Pair(1.5, 600),
                                        Pair(12.0, 1300), Pair(20.0, 1399)));
   // invalid string.
   buckets_str = "0.0,400,1.5,600";
   EXPECT_FALSE(
       ScoredHistoryMatch::GetHQPBucketsFromString(buckets_str, &hqp_buckets));
 }