Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2355053002: (reland) Do not let text-size-adjust override accessibility font settings (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

(reland) Do not let text-size-adjust override accessibility font settings The text autosizer is used for both making desktop pages more legible on mobile, and for applying the accessibility font scale factor. When text-size-adjust support was added, pages were able to override the accessibility setting in addition to the autosizing multiplier. This patch ensures accessibility font scale settings are respected even with text-size-adjust. A followup bug has been filed (crbug.com/645717) for moving the accessibility font scale factor out of the autosizer. This patch also re-enables support for text-size-adjust which was disabled temporarily due to breaking accessibility settings. This was reverted due to a forgotten "!" in checking whether the viewport was specified by the author in TextAutosizer.cpp. A new test has been added to catch this in the future. The unneeded meta viewport declarations in all other tests have been removed because they had no effect with the meta viewport setting disabled. Original review: https://codereview.chromium.org/2329733002 BUG=645269, 646342 Review-Url: https://codereview.chromium.org/2340553003 Cr-Commit-Position: refs/heads/master@{#418488} (cherry picked from commit 1229b1414d64c314666d2fb3bf47706f2b5e947b) Committed: https://chromium.googlesource.com/chromium/src/+/d25ac697753f02ac5c923d65402d75b4211cab28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -33 lines) Patch
M third_party/WebKit/Source/core/layout/TextAutosizer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 4 chunks +22 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp View 9 chunks +161 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pdr.
4 years, 3 months ago (2016-09-20 18:02:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d25ac697753f02ac5c923d65402d75b4211cab28.

Powered by Google App Engine
This is Rietveld 408576698