(reland) Do not let text-size-adjust override accessibility font settings

(reland) Do not let text-size-adjust override accessibility font settings

The text autosizer is used for both making desktop pages more legible
on mobile, and for applying the accessibility font scale factor. When
text-size-adjust support was added, pages were able to override the
accessibility setting in addition to the autosizing multiplier.

This patch ensures accessibility font scale settings are respected even
with text-size-adjust. A followup bug has been filed (crbug.com/645717)
for moving the accessibility font scale factor out of the autosizer.

This patch also re-enables support for text-size-adjust which was
disabled temporarily due to breaking accessibility settings.

This was reverted due to a forgotten "!" in checking whether the
viewport was specified by the author in TextAutosizer.cpp. A new test
has been added to catch this in the future. The unneeded meta viewport
declarations in all other tests have been removed because they had
no effect with the meta viewport setting disabled.

Original review:
https://codereview.chromium.org/2329733002

BUG=645269, 646342
Committed: https://crrev.com/1229b1414d64c314666d2fb3bf47706f2b5e947b
Cr-Commit-Position: refs/heads/master@{#418488}

[pdr., 2016-09-14 02:24:54]

Description was changed from

==========
(reland) Do not let text-size-adjust override accessibility font settings

The text autosizer is used for both making desktop pages more legible
on mobile, and for applying the accessibility font scale factor. When
text-size-adjust support was added, pages were able to override the
accessibility setting in addition to the autosizing multiplier.

This patch ensures accessibility font scale settings are respected even
with text-size-adjust. A followup bug has been filed (crbug.com/645717)
for moving the accessibility font scale factor out of the autosizer.

This patch also re-enables support for text-size-adjust which was
disabled temporarily due to breaking accessibility settings.

BUG=645269
==========

to

==========
(reland) Do not let text-size-adjust override accessibility font settings

The text autosizer is used for both making desktop pages more legible
on mobile, and for applying the accessibility font scale factor. When
text-size-adjust support was added, pages were able to override the
accessibility setting in addition to the autosizing multiplier.

This patch ensures accessibility font scale settings are respected even
with text-size-adjust. A followup bug has been filed (crbug.com/645717)
for moving the accessibility font scale factor out of the autosizer.

This patch also re-enables support for text-size-adjust which was
disabled temporarily due to breaking accessibility settings.

This was reverted due to a forgotten "!" in checking whether the
viewport was specified by the author in TextAutosizer.cpp. A new test
has been added to catch this in the future. The unneeded meta viewport
declarations in all other tests have been removed because they had
no effect with the meta viewport setting disabled.

BUG=645269
==========

[pdr., 2016-09-14 02:24:54]

pdr@chromium.org changed reviewers:
+ skobes@chromium.org

[pdr., 2016-09-14 02:27:40]

Description was changed from

==========
(reland) Do not let text-size-adjust override accessibility font settings

The text autosizer is used for both making desktop pages more legible
on mobile, and for applying the accessibility font scale factor. When
text-size-adjust support was added, pages were able to override the
accessibility setting in addition to the autosizing multiplier.

This patch ensures accessibility font scale settings are respected even
with text-size-adjust. A followup bug has been filed (crbug.com/645717)
for moving the accessibility font scale factor out of the autosizer.

This patch also re-enables support for text-size-adjust which was
disabled temporarily due to breaking accessibility settings.

This was reverted due to a forgotten "!" in checking whether the
viewport was specified by the author in TextAutosizer.cpp. A new test
has been added to catch this in the future. The unneeded meta viewport
declarations in all other tests have been removed because they had
no effect with the meta viewport setting disabled.

BUG=645269
==========

to

==========
(reland) Do not let text-size-adjust override accessibility font settings

The text autosizer is used for both making desktop pages more legible
on mobile, and for applying the accessibility font scale factor. When
text-size-adjust support was added, pages were able to override the
accessibility setting in addition to the autosizing multiplier.

This patch ensures accessibility font scale settings are respected even
with text-size-adjust. A followup bug has been filed (crbug.com/645717)
for moving the accessibility font scale factor out of the autosizer.

This patch also re-enables support for text-size-adjust which was
disabled temporarily due to breaking accessibility settings.

This was reverted due to a forgotten "!" in checking whether the
viewport was specified by the author in TextAutosizer.cpp. A new test
has been added to catch this in the future. The unneeded meta viewport
declarations in all other tests have been removed because they had
no effect with the meta viewport setting disabled.

Original review:
https://codereview.chromium.org/2329733002

BUG=645269
==========

[pdr., 2016-09-14 02:29:35]

https://codereview.chromium.org/2340553003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/TextAutosizer.cpp (right):

https://codereview.chromium.org/2340553003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/TextAutosizer.cpp:559: if
(!mainFrame->document()->viewportDescription().isSpecifiedByAuthor())
The original patch was rolled out because this line was missing the "!". I was
surprised we had no test coverage of this behavior so I've added a new test in
this patch. A followup will fix the setting invalidation bug so that changing
viewport settings invalidates text autosizing too.

[pdr., 2016-09-14 02:32:25]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 02:33:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2016-09-14 02:34:38]

lgtm w/ nit

https://codereview.chromium.org/2340553003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp (right):

https://codereview.chromium.org/2340553003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp:341:
TEST_F(TextAutosizerTest, DISABLED_TextSizeAdjustWithMetaViewport)
Should this test be renamed, or updated to call setViewportMetaEnabled(true)?

[pdr., 2016-09-14 02:50:51]

On 2016/09/14 at 02:34:38, skobes wrote:
> lgtm w/ nit
> 
>
https://codereview.chromium.org/2340553003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp (right):
> 
>
https://codereview.chromium.org/2340553003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp:341:
TEST_F(TextAutosizerTest, DISABLED_TextSizeAdjustWithMetaViewport)
> Should this test be renamed, or updated to call setViewportMetaEnabled(true)?

Good catch, I've renamed it DISABLED_TextSizeAdjustWithoutNeedingAutosizing and
double-checked that it still fails as expected.

[pdr., 2016-09-14 02:51:19]

Description was changed from

==========
(reland) Do not let text-size-adjust override accessibility font settings

The text autosizer is used for both making desktop pages more legible
on mobile, and for applying the accessibility font scale factor. When
text-size-adjust support was added, pages were able to override the
accessibility setting in addition to the autosizing multiplier.

This patch ensures accessibility font scale settings are respected even
with text-size-adjust. A followup bug has been filed (crbug.com/645717)
for moving the accessibility font scale factor out of the autosizer.

This patch also re-enables support for text-size-adjust which was
disabled temporarily due to breaking accessibility settings.

This was reverted due to a forgotten "!" in checking whether the
viewport was specified by the author in TextAutosizer.cpp. A new test
has been added to catch this in the future. The unneeded meta viewport
declarations in all other tests have been removed because they had
no effect with the meta viewport setting disabled.

Original review:
https://codereview.chromium.org/2329733002

BUG=645269
==========

to

==========
(reland) Do not let text-size-adjust override accessibility font settings

The text autosizer is used for both making desktop pages more legible
on mobile, and for applying the accessibility font scale factor. When
text-size-adjust support was added, pages were able to override the
accessibility setting in addition to the autosizing multiplier.

This patch ensures accessibility font scale settings are respected even
with text-size-adjust. A followup bug has been filed (crbug.com/645717)
for moving the accessibility font scale factor out of the autosizer.

This patch also re-enables support for text-size-adjust which was
disabled temporarily due to breaking accessibility settings.

This was reverted due to a forgotten "!" in checking whether the
viewport was specified by the author in TextAutosizer.cpp. A new test
has been added to catch this in the future. The unneeded meta viewport
declarations in all other tests have been removed because they had
no effect with the meta viewport setting disabled.

Original review:
https://codereview.chromium.org/2329733002

BUG=645269,646342
==========

[pdr., 2016-09-14 02:53:11]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-09-14 02:53:11]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2340553003/#ps40001
(title: "Rename test DISABLED_TextSizeAdjustWithoutNeedingAutosizing")

[commit-bot: I haz the power, 2016-09-14 02:53:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 04:41:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 04:43:13]

Description was changed from

==========
(reland) Do not let text-size-adjust override accessibility font settings

The text autosizer is used for both making desktop pages more legible
on mobile, and for applying the accessibility font scale factor. When
text-size-adjust support was added, pages were able to override the
accessibility setting in addition to the autosizing multiplier.

This patch ensures accessibility font scale settings are respected even
with text-size-adjust. A followup bug has been filed (crbug.com/645717)
for moving the accessibility font scale factor out of the autosizer.

This patch also re-enables support for text-size-adjust which was
disabled temporarily due to breaking accessibility settings.

This was reverted due to a forgotten "!" in checking whether the
viewport was specified by the author in TextAutosizer.cpp. A new test
has been added to catch this in the future. The unneeded meta viewport
declarations in all other tests have been removed because they had
no effect with the meta viewport setting disabled.

Original review:
https://codereview.chromium.org/2329733002

BUG=645269,646342
==========

to

==========
(reland) Do not let text-size-adjust override accessibility font settings

The text autosizer is used for both making desktop pages more legible
on mobile, and for applying the accessibility font scale factor. When
text-size-adjust support was added, pages were able to override the
accessibility setting in addition to the autosizing multiplier.

This patch ensures accessibility font scale settings are respected even
with text-size-adjust. A followup bug has been filed (crbug.com/645717)
for moving the accessibility font scale factor out of the autosizer.

This patch also re-enables support for text-size-adjust which was
disabled temporarily due to breaking accessibility settings.

This was reverted due to a forgotten "!" in checking whether the
viewport was specified by the author in TextAutosizer.cpp. A new test
has been added to catch this in the future. The unneeded meta viewport
declarations in all other tests have been removed because they had
no effect with the meta viewport setting disabled.

Original review:
https://codereview.chromium.org/2329733002

BUG=645269,646342

Committed: https://crrev.com/1229b1414d64c314666d2fb3bf47706f2b5e947b
Cr-Commit-Position: refs/heads/master@{#418488}
==========

[commit-bot: I haz the power, 2016-09-14 04:43:14]

Patchset 3 (id:??) landed as
https://crrev.com/1229b1414d64c314666d2fb3bf47706f2b5e947b
Cr-Commit-Position: refs/heads/master@{#418488}