[modules] Add a requested_modules field to Module

[modules] Add a requested_modules field to Module

Also simplify Factory::NewModule to take only the SharedFunctionInfo.

R=neis@chromium.org
BUG=v8:1569
Committed: https://crrev.com/c604eae3c258354c5a73c6eff0e18f39bc820fa6
Cr-Commit-Position: refs/heads/master@{#39563}

[neis, 2016-09-20 18:07:20]

lgtm with two comments

https://codereview.chromium.org/2355033002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2355033002/diff/1/src/api.cc#newcode2060
src/api.cc:2060: int regular_exports_length = regular_exports->length();
Since the length now isn't used elsewhere, I would prefer to move it into the
for:

for (int i = 0, n = regular_exports_length; i < n; ++i)

https://codereview.chromium.org/2355033002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2355033002/diff/1/src/objects.h#newcode7887
src/objects.h:7887: // [[RequestedModules]]: Modules imported or re-exported by
this module.
Please mention that it matches the module_requests array in the ModuleInfo.

[adamk, 2016-09-20 18:16:16]

https://codereview.chromium.org/2355033002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2355033002/diff/1/src/api.cc#newcode2060
src/api.cc:2060: int regular_exports_length = regular_exports->length();
On 2016/09/20 18:07:20, neis wrote:
> Since the length now isn't used elsewhere, I would prefer to move it into the
> for:
> 
> for (int i = 0, n = regular_exports_length; i < n; ++i)

Done.

https://codereview.chromium.org/2355033002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2355033002/diff/1/src/objects.h#newcode7887
src/objects.h:7887: // [[RequestedModules]]: Modules imported or re-exported by
this module.
On 2016/09/20 18:07:20, neis wrote:
> Please mention that it matches the module_requests array in the ModuleInfo.

Done.

[adamk, 2016-09-20 18:16:20]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-09-20 18:16:20]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2355033002/#ps20001
(title: "Handle review comments")

[commit-bot: I haz the power, 2016-09-20 18:16:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 18:50:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 18:51:04]

Description was changed from

==========
[modules] Add a requested_modules field to Module

Also simplify Factory::NewModule to take only the SharedFunctionInfo.

R=neis@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Add a requested_modules field to Module

Also simplify Factory::NewModule to take only the SharedFunctionInfo.

R=neis@chromium.org
BUG=v8:1569

Committed: https://crrev.com/c604eae3c258354c5a73c6eff0e18f39bc820fa6
Cr-Commit-Position: refs/heads/master@{#39563}
==========

[commit-bot: I haz the power, 2016-09-20 18:51:07]

Patchset 2 (id:??) landed as
https://crrev.com/c604eae3c258354c5a73c6eff0e18f39bc820fa6
Cr-Commit-Position: refs/heads/master@{#39563}