Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2355033002: [modules] Add a requested_modules field to Module (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Add a requested_modules field to Module Also simplify Factory::NewModule to take only the SharedFunctionInfo. R=neis@chromium.org BUG=v8:1569 Committed: https://crrev.com/c604eae3c258354c5a73c6eff0e18f39bc820fa6 Cr-Commit-Position: refs/heads/master@{#39563}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Handle review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -13 lines) Patch
M src/api.cc View 1 1 chunk +5 lines, -8 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
adamk
4 years, 3 months ago (2016-09-20 17:38:59 UTC) #1
neis
lgtm with two comments https://codereview.chromium.org/2355033002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/2355033002/diff/1/src/api.cc#newcode2060 src/api.cc:2060: int regular_exports_length = regular_exports->length(); Since ...
4 years, 3 months ago (2016-09-20 18:07:20 UTC) #2
adamk
https://codereview.chromium.org/2355033002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/2355033002/diff/1/src/api.cc#newcode2060 src/api.cc:2060: int regular_exports_length = regular_exports->length(); On 2016/09/20 18:07:20, neis wrote: ...
4 years, 3 months ago (2016-09-20 18:16:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355033002/20001
4 years, 3 months ago (2016-09-20 18:16:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 18:50:05 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 18:51:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c604eae3c258354c5a73c6eff0e18f39bc820fa6
Cr-Commit-Position: refs/heads/master@{#39563}

Powered by Google App Engine
This is Rietveld 408576698