[modules] Add a requested_modules field to Module

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 2030 matching lines @@
 
 MaybeLocal<Module> ScriptCompiler::CompileModule(Isolate* isolate,
                                                  Source* source) {
   i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
 
   auto maybe = CompileUnboundInternal(isolate, source, kNoCompileOptions, true);
   Local<UnboundScript> unbound;
   if (!maybe.ToLocal(&unbound)) return MaybeLocal<Module>();
 
   i::Handle<i::SharedFunctionInfo> shared = Utils::OpenHandle(*unbound);
-  i::Handle<i::FixedArray> regular_exports =
-      i::handle(shared->scope_info()->ModuleDescriptorInfo()->regular_exports(),
-                i_isolate);
-  int regular_exports_length = regular_exports->length();
-
-  i::Handle<i::Module> module =
-      i_isolate->factory()->NewModule(shared, regular_exports_length);
+  i::Handle<i::Module> module = i_isolate->factory()->NewModule(shared);
 
   // TODO(neis): This will create multiple cells for the same local variable if
   // exported under multiple names, which is wrong but cannot be observed at the
   // moment. This will be fixed by doing the full-fledged linking here once we
   // get there.
+  i::Handle<i::FixedArray> regular_exports =
+      i::handle(shared->scope_info()->ModuleDescriptorInfo()->regular_exports(),
+                i_isolate);
+  int regular_exports_length = regular_exports->length();

[neis, 2016/09/20 18:07:20]

Since the length now isn't used elsewhere, I would prefer to move it into the
for:

for (int i = 0, n = regular_exports_length; i < n; ++i)

[adamk, 2016/09/20 18:16:16]

Done.

   for (int i = 0; i < regular_exports_length; ++i) {
     i::Handle<i::ModuleInfoEntry> entry =
         i::handle(i::ModuleInfoEntry::cast(regular_exports->get(i)), i_isolate);
     DCHECK(entry->import_name()->IsUndefined(i_isolate));
     i::Handle<i::String> export_name =
         handle(i::String::cast(entry->export_name()), i_isolate);
     i::Module::CreateExport(module, export_name);
   }
 
   return ToApiHandle<Module>(module);
@@ skipping 7299 matching lines @@
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 }  // namespace internal
 }  // namespace v8