Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2354983002: Fix LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test (Closed)

Created:
4 years, 3 months ago by ericrk
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test was incorrectly relying on WillBeginImplFrameOnThread only being called once after the OutputSurface was recreated. In reality, this function could be called multiple times. This patch causes us to handle cleanup in DidInitializeOutputSurface, which will only be called once after recreating an OutputSurface. BUG=642881, 642836 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2297413002 Cr-Commit-Position: refs/heads/master@{#415791} (cherry picked from commit 1e16f5f83b5a634369a7e9d82fddfe2e1ec10a9d) Committed: https://chromium.googlesource.com/chromium/src/+/2a2b4b5a2d2a62d8f1c8fc6d86b53e561aaecd25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +22 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ericrk
4 years, 3 months ago (2016-09-20 16:06:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a2b4b5a2d2a62d8f1c8fc6d86b53e561aaecd25.

Powered by Google App Engine
This is Rietveld 408576698