Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2297413002: Fix LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test (Closed)

Created:
4 years, 3 months ago by ericrk
Modified:
4 years, 3 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test was incorrectly relying on WillBeginImplFrameOnThread only being called once after the OutputSurface was recreated. In reality, this function could be called multiple times. This patch causes us to handle cleanup in DidInitializeOutputSurface, which will only be called once after recreating an OutputSurface. BUG=642881, 642836 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1e16f5f83b5a634369a7e9d82fddfe2e1ec10a9d Cr-Commit-Position: refs/heads/master@{#415791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +22 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
ericrk
Can you take a look at this build bot fix?
4 years, 3 months ago (2016-08-31 21:54:13 UTC) #5
vmpstr
lgtm
4 years, 3 months ago (2016-08-31 22:51:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297413002/40001
4 years, 3 months ago (2016-08-31 22:52:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 3 months ago (2016-08-31 22:56:25 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:57:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e16f5f83b5a634369a7e9d82fddfe2e1ec10a9d
Cr-Commit-Position: refs/heads/master@{#415791}

Powered by Google App Engine
This is Rietveld 408576698