Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: content/browser/devtools/protocol/service_worker_handler.h

Issue 2354973003: [DevTools] Move subtargets functionality from ServiceWorker to Target domain. (Closed)
Patch Set: review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/service_worker_handler.h
diff --git a/content/browser/devtools/protocol/service_worker_handler.h b/content/browser/devtools/protocol/service_worker_handler.h
index ac7d460cafb1866ebc51d3404f64e9034f87f8cf..892a8c7ec031fbfbfea541a0956698e833390dcc 100644
--- a/content/browser/devtools/protocol/service_worker_handler.h
+++ b/content/browser/devtools/protocol/service_worker_handler.h
@@ -33,25 +33,20 @@ class ServiceWorkerContextWrapper;
namespace devtools {
namespace service_worker {
-class ServiceWorkerHandler : public DevToolsAgentHostClient,
- public ServiceWorkerDevToolsManager::Observer {
+class ServiceWorkerHandler {
public:
typedef DevToolsProtocolClient::Response Response;
ServiceWorkerHandler();
- ~ServiceWorkerHandler() override;
+ ~ServiceWorkerHandler();
void SetRenderFrameHost(RenderFrameHostImpl* render_frame_host);
void SetClient(std::unique_ptr<Client> client);
- void UpdateHosts();
void Detached();
// Protocol 'service worker' domain implementation.
Response Enable();
Response Disable();
- Response SendMessage(const std::string& worker_id,
- const std::string& message);
- Response Stop(const std::string& worker_id);
Response Unregister(const std::string& scope_url);
Response StartWorker(const std::string& scope_url);
Response SkipWaiting(const std::string& scope_url);
@@ -66,27 +61,8 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
const std::string& registration_id,
const std::string& tag,
bool last_chance);
- Response GetTargetInfo(const std::string& target_id,
- scoped_refptr<TargetInfo>* target_info);
- Response ActivateTarget(const std::string& target_id);
-
- // WorkerDevToolsManager::Observer implementation.
- void WorkerCreated(ServiceWorkerDevToolsAgentHost* host) override;
- void WorkerReadyForInspection(ServiceWorkerDevToolsAgentHost* host) override;
- void WorkerVersionInstalled(ServiceWorkerDevToolsAgentHost* host) override;
- void WorkerVersionDoomed(ServiceWorkerDevToolsAgentHost* host) override;
- void WorkerDestroyed(ServiceWorkerDevToolsAgentHost* host) override;
private:
- // DevToolsAgentHostClient overrides.
- void DispatchProtocolMessage(DevToolsAgentHost* agent_host,
- const std::string& message) override;
- void AgentHostClosed(DevToolsAgentHost* agent_host,
- bool replaced_with_another_client) override;
-
- void ReportWorkerCreated(ServiceWorkerDevToolsAgentHost* host);
- void ReportWorkerTerminated(ServiceWorkerDevToolsAgentHost* host);
-
void OnWorkerRegistrationUpdated(
const std::vector<ServiceWorkerRegistrationInfo>& registrations);
void OnWorkerVersionUpdated(
@@ -100,9 +76,7 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
scoped_refptr<ServiceWorkerContextWrapper> context_;
std::unique_ptr<Client> client_;
- ServiceWorkerDevToolsAgentHost::Map attached_hosts_;
bool enabled_;
- std::set<GURL> urls_;
scoped_refptr<ServiceWorkerContextWatcher> context_watcher_;
RenderFrameHostImpl* render_frame_host_;
« no previous file with comments | « content/browser/devtools/protocol/schema_handler.cc ('k') | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698