Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: content/browser/devtools/protocol/schema_handler.cc

Issue 2354973003: [DevTools] Move subtargets functionality from ServiceWorker to Target domain. (Closed)
Patch Set: review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/BUILD.gn ('k') | content/browser/devtools/protocol/service_worker_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/schema_handler.cc
diff --git a/content/browser/devtools/protocol/schema_handler.cc b/content/browser/devtools/protocol/schema_handler.cc
index 608e0286538be1ac6441166f9bff751f8c5b9f2b..93d3e1f9d64b617ee5c48306b8108027fdf5de8e 100644
--- a/content/browser/devtools/protocol/schema_handler.cc
+++ b/content/browser/devtools/protocol/schema_handler.cc
@@ -18,6 +18,7 @@ SchemaHandler::~SchemaHandler() {
Response SchemaHandler::GetDomains(
std::vector<scoped_refptr<Domain>>* domains) {
+ // TODO(kozyatisnkiy): get this from the target instead of hardcoding a list.
static const char kVersion[] = "1.2";
static const char* kDomains[] = {
"Inspector", "Memory", "Page", "Rendering", "Emulation", "Security",
@@ -25,7 +26,7 @@ Response SchemaHandler::GetDomains(
"ApplicationCache", "DOM", "IO", "DOMDebugger", "Worker", "ServiceWorker",
"Input", "LayerTree", "DeviceOrientation", "Tracing", "Animation",
"Accessibility", "Storage", "Log", "Browser", "Runtime", "Debugger",
- "Profiler", "HeapProfiler", "Schema"
+ "Profiler", "HeapProfiler", "Schema", "Target"
};
for (size_t i = 0; i < arraysize(kDomains); ++i) {
domains->push_back(Domain::Create()
« no previous file with comments | « content/browser/BUILD.gn ('k') | content/browser/devtools/protocol/service_worker_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698