Add toSVGLengthType() and toSVGLengthMode() fuctions, and use it.

Add toSVGLengthType() and toSVGLengthMode() fuctions, and use it.

These functions have type checking assertions for helping to find bad-cast bugs.

BUG=N/A

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157877

[gyuyoung-inactive, 2013-09-12 09:08:04]

Add tkent to reviewer. kent, please take a look.

[tkent, 2013-09-12 22:40:34]

This patch doesn't look helpful.
unsigned short - SVGLengthFoo conversion is a matter only in SVGLength
implementation, and is not exposed to other classes.

https://codereview.chromium.org/23549032/diff/1/Source/core/svg/SVGLength.h
File Source/core/svg/SVGLength.h (right):

https://codereview.chromium.org/23549032/diff/1/Source/core/svg/SVGLength.h#n...
Source/core/svg/SVGLength.h:171: inline SVGLengthMode toSVGLengthMode(unsigned
short mode)
We must need this type conversion only in SVGLength.cpp. We should implement
this function in SVGLength.cpp.

https://codereview.chromium.org/23549032/diff/1/Source/core/svg/SVGLength.h#n...
Source/core/svg/SVGLength.h:173: ASSERT_WITH_SECURITY_IMPLICATION(!mode || mode
> LengthModeOther);
I don't think this has security implication. Also, the assertion looks wrong.

https://codereview.chromium.org/23549032/diff/1/Source/core/svg/SVGLength.h#n...
Source/core/svg/SVGLength.h:177: inline SVGLengthType toSVGLengthType(unsigned
short type)
Same comments.

[gyuyoung-inactive, 2013-09-17 00:14:32]

On 2013/09/12 22:40:34, tkent wrote:
> This patch doesn't look helpful.
> unsigned short - SVGLengthFoo conversion is a matter only in SVGLength
> implementation, and is not exposed to other classes.
> 
> https://codereview.chromium.org/23549032/diff/1/Source/core/svg/SVGLength.h
> File Source/core/svg/SVGLength.h (right):
> 
>
https://codereview.chromium.org/23549032/diff/1/Source/core/svg/SVGLength.h#n...
> Source/core/svg/SVGLength.h:171: inline SVGLengthMode toSVGLengthMode(unsigned
> short mode)
> We must need this type conversion only in SVGLength.cpp. We should implement
> this function in SVGLength.cpp.
> 
>
https://codereview.chromium.org/23549032/diff/1/Source/core/svg/SVGLength.h#n...
> Source/core/svg/SVGLength.h:173: ASSERT_WITH_SECURITY_IMPLICATION(!mode ||
mode
> > LengthModeOther);
> I don't think this has security implication. Also, the assertion looks wrong.
> 
>
https://codereview.chromium.org/23549032/diff/1/Source/core/svg/SVGLength.h#n...
> Source/core/svg/SVGLength.h:177: inline SVGLengthType toSVGLengthType(unsigned
> short type)
> Same comments.

kent, how do you think latest patch ?

[tkent, 2013-09-17 01:44:53]

lgtm

[commit-bot: I haz the power, 2013-09-17 01:45:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23549032/10001

[commit-bot: I haz the power, 2013-09-17 02:40:35]

Change committed as 157877