Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: Source/core/svg/SVGLength.h

Issue 23549032: Add toSVGLengthType() and toSVGLengthMode() fuctions, and use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/svg/SVGLength.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 float m_valueInSpecifiedUnits; 161 float m_valueInSpecifiedUnits;
162 unsigned int m_unit; 162 unsigned int m_unit;
163 }; 163 };
164 164
165 template<> 165 template<>
166 struct SVGPropertyTraits<SVGLength> { 166 struct SVGPropertyTraits<SVGLength> {
167 static SVGLength initialValue() { return SVGLength(); } 167 static SVGLength initialValue() { return SVGLength(); }
168 static String toString(const SVGLength& type) { return type.valueAsString(); } 168 static String toString(const SVGLength& type) { return type.valueAsString(); }
169 }; 169 };
170 170
171 inline SVGLengthMode toSVGLengthMode(unsigned short mode)
tkent 2013/09/12 22:40:34 We must need this type conversion only in SVGLengt
172 {
173 ASSERT_WITH_SECURITY_IMPLICATION(!mode || mode > LengthModeOther);
tkent 2013/09/12 22:40:34 I don't think this has security implication. Also,
174 return static_cast<SVGLengthMode>(mode);
175 }
176
177 inline SVGLengthType toSVGLengthType(unsigned short type)
tkent 2013/09/12 22:40:34 Same comments.
178 {
179 ASSERT_WITH_SECURITY_IMPLICATION(!type || (type == LengthTypeUnknown || type > LengthTypePC));
180 return static_cast<SVGLengthType>(type);
181 }
171 182
172 } // namespace WebCore 183 } // namespace WebCore
173 184
174 #endif // SVGLength_h 185 #endif // SVGLength_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/svg/SVGLength.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698