[turbofan] Also allow TaggedSigned/Pointer memory operand.

[turbofan] Also allow TaggedSigned/Pointer memory operand.

When we added the new MachineRepresentation::kTaggedSigned and
MachineRepresentation::kTaggedPointer, we didn't extend the logic
for memory operand covering, and so for map checks and other
comparisons with fields we'd always need an additional register.
This fixes that and does reduce register pressure in some cases.

R=jarin@chromium.org
BUG=v8:5267, v8:5270
Committed: https://crrev.com/b0b97bfc0f3043058a479f62d3f4f0ea9995e6e5
Cr-Commit-Position: refs/heads/master@{#39575}

[Benedikt Meurer, 2016-09-21 06:47:44]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 06:47:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2016-09-21 06:49:55]

lgtm

https://codereview.chromium.org/2354863003/diff/1/src/compiler/x64/instructio...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/2354863003/diff/1/src/compiler/x64/instructio...
src/compiler/x64/instruction-selector-x64.cc:66: rep ==
MachineRepresentation::kTaggedPointer;
IsAnyTagged(rep) ?

[Benedikt Meurer, 2016-09-21 06:50:00]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-09-21 06:50:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-09-21 06:50:10]

https://codereview.chromium.org/2354863003/diff/1/src/compiler/x64/instructio...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/2354863003/diff/1/src/compiler/x64/instructio...
src/compiler/x64/instruction-selector-x64.cc:66: rep ==
MachineRepresentation::kTaggedPointer;
On 2016/09/21 06:49:55, Jarin wrote:
> IsAnyTagged(rep) ?

Done.

[commit-bot: I haz the power, 2016-09-21 07:14:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 07:15:33]

Description was changed from

==========
[turbofan] Also allow TaggedSigned/Pointer memory operand.

When we added the new MachineRepresentation::kTaggedSigned and
MachineRepresentation::kTaggedPointer, we didn't extend the logic
for memory operand covering, and so for map checks and other
comparisons with fields we'd always need an additional register.
This fixes that and does reduce register pressure in some cases.

R=jarin@chromium.org
BUG=v8:5267,v8:5270
==========

to

==========
[turbofan] Also allow TaggedSigned/Pointer memory operand.

When we added the new MachineRepresentation::kTaggedSigned and
MachineRepresentation::kTaggedPointer, we didn't extend the logic
for memory operand covering, and so for map checks and other
comparisons with fields we'd always need an additional register.
This fixes that and does reduce register pressure in some cases.

R=jarin@chromium.org
BUG=v8:5267,v8:5270

Committed: https://crrev.com/b0b97bfc0f3043058a479f62d3f4f0ea9995e6e5
Cr-Commit-Position: refs/heads/master@{#39575}
==========

[commit-bot: I haz the power, 2016-09-21 07:15:33]

Patchset 2 (id:??) landed as
https://crrev.com/b0b97bfc0f3043058a479f62d3f4f0ea9995e6e5
Cr-Commit-Position: refs/heads/master@{#39575}