Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Side by Side Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 2354863003: [turbofan] Also allow TaggedSigned/Pointer memory operand. (Closed)
Patch Set: Use the helper method instead. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 6
7 #include "src/base/adapters.h" 7 #include "src/base/adapters.h"
8 #include "src/compiler/instruction-selector-impl.h" 8 #include "src/compiler/instruction-selector-impl.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/compiler/node-properties.h" 10 #include "src/compiler/node-properties.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 return false; 53 return false;
54 } 54 }
55 if (effect_level != selector()->GetEffectLevel(input)) { 55 if (effect_level != selector()->GetEffectLevel(input)) {
56 return false; 56 return false;
57 } 57 }
58 MachineRepresentation rep = 58 MachineRepresentation rep =
59 LoadRepresentationOf(input->op()).representation(); 59 LoadRepresentationOf(input->op()).representation();
60 switch (opcode) { 60 switch (opcode) {
61 case kX64Cmp: 61 case kX64Cmp:
62 case kX64Test: 62 case kX64Test:
63 return rep == MachineRepresentation::kWord64 || 63 return rep == MachineRepresentation::kWord64 || IsAnyTagged(rep);
64 rep == MachineRepresentation::kTagged;
65 case kX64Cmp32: 64 case kX64Cmp32:
66 case kX64Test32: 65 case kX64Test32:
67 return rep == MachineRepresentation::kWord32; 66 return rep == MachineRepresentation::kWord32;
68 case kX64Cmp16: 67 case kX64Cmp16:
69 case kX64Test16: 68 case kX64Test16:
70 return rep == MachineRepresentation::kWord16; 69 return rep == MachineRepresentation::kWord16;
71 case kX64Cmp8: 70 case kX64Cmp8:
72 case kX64Test8: 71 case kX64Test8:
73 return rep == MachineRepresentation::kWord8; 72 return rep == MachineRepresentation::kWord8;
74 default: 73 default:
(...skipping 2217 matching lines...) Expand 10 before | Expand all | Expand 10 after
2292 // static 2291 // static
2293 MachineOperatorBuilder::AlignmentRequirements 2292 MachineOperatorBuilder::AlignmentRequirements
2294 InstructionSelector::AlignmentRequirements() { 2293 InstructionSelector::AlignmentRequirements() {
2295 return MachineOperatorBuilder::AlignmentRequirements:: 2294 return MachineOperatorBuilder::AlignmentRequirements::
2296 FullUnalignedAccessSupport(); 2295 FullUnalignedAccessSupport();
2297 } 2296 }
2298 2297
2299 } // namespace compiler 2298 } // namespace compiler
2300 } // namespace internal 2299 } // namespace internal
2301 } // namespace v8 2300 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698