Web Share: Show a warning prompt when share is used from incognito.

Web Share: Show a warning prompt when share is used from incognito.

This is the same dialog as shown when external links are opened from
incognito, informing the user that they are leaving incognito mode and
potentially sharing data with an external application.

BUG=645007
Committed: https://crrev.com/7db85418178d9d4f01a7901da7450e40e08414ec
Cr-Commit-Position: refs/heads/master@{#420564}

[Matt Giuca, 2016-09-20 05:53:41]

mgiuca@chromium.org changed reviewers:
+ sammc@chromium.org

[Matt Giuca, 2016-09-20 05:53:42]

Screenshot on bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=645006

So as not to block on https://codereview.chromium.org/2338203002/, I will add an
end-to-end test for this in a follow-up CL.

[Matt Giuca, 2016-09-20 06:01:57]

On 2016/09/20 05:53:42, Matt Giuca wrote:
> Screenshot on bug:
> https://bugs.chromium.org/p/chromium/issues/detail?id=645006
> 
> So as not to block on https://codereview.chromium.org/2338203002/, I will add
an
> end-to-end test for this in a follow-up CL.

New plan: link to right bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=645007#c1

[Sam McNally, 2016-09-20 07:00:39]

lgtm

[Matt Giuca, 2016-09-21 00:21:56]

mgiuca@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Matt Giuca, 2016-09-21 00:21:57]

+tedchoc for OWNERS. Thanks!

[Matt Giuca, 2016-09-21 03:01:04]

Patchset #2 (id:20001) has been deleted

[Ted C, 2016-09-21 20:26:53]

lgtm

https://codereview.chromium.org/2354833002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/2354833002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:367:
public static void showLeaveIncognitoWarningDialog(Activity activity,
we should add javadoc for public methods

[Matt Giuca, 2016-09-22 07:03:02]

https://codereview.chromium.org/2354833002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/2354833002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:367:
public static void showLeaveIncognitoWarningDialog(Activity activity,
On 2016/09/21 20:26:53, Ted C wrote:
> we should add javadoc for public methods

Done.

[Matt Giuca, 2016-09-23 01:42:17]

I've removed the dependency on CL 2354613005, as that seems to be controversial.

This can now land by itself, but it will have the old dialog text.

[Matt Giuca, 2016-09-23 01:42:26]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-09-23 01:42:26]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org,
tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2354833002/#ps120001
(title: "Un-rebase from CL 2354613005.")

[commit-bot: I haz the power, 2016-09-23 01:42:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 02:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:29:49]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Matt Giuca, 2016-09-23 02:43:47]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-09-23 02:43:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/2354833002/#ps140001
(title: "Remove unused local variable.")

[commit-bot: I haz the power, 2016-09-23 02:44:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:19:50]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-09-23 03:21:14]

Description was changed from

==========
Web Share: Show a warning prompt when share is used from incognito.

This is the same dialog as shown when external links are opened from
incognito, informing the user that they are leaving incognito mode and
potentially sharing data with an external application.

BUG=645007
==========

to

==========
Web Share: Show a warning prompt when share is used from incognito.

This is the same dialog as shown when external links are opened from
incognito, informing the user that they are leaving incognito mode and
potentially sharing data with an external application.

BUG=645007

Committed: https://crrev.com/7db85418178d9d4f01a7901da7450e40e08414ec
Cr-Commit-Position: refs/heads/master@{#420564}
==========

[commit-bot: I haz the power, 2016-09-23 03:21:15]

Patchset 7 (id:??) landed as
https://crrev.com/7db85418178d9d4f01a7901da7450e40e08414ec
Cr-Commit-Position: refs/heads/master@{#420564}