Don't set the request target type to object when navigating from a Pepper plug-in.

content/renderer/pepper/pepper_plugin_instance_impl.cc

Index: content/renderer/pepper/pepper_plugin_instance_impl.cc
diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc
index fd57f0896db531a7193cdecc7813417a7254bb60..ea9160df7c427fbf5adff10423739d0e07666fe4 100644
--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc
+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc
@@ -2757,10 +2757,14 @@ int32_t PepperPluginInstanceImpl::Navigate(
 
   WebURLRequest web_request;
   if (!CreateWebURLRequest(&completed_request,
-                           WebURLRequest::TargetIsMainFrame,
+                           frame->parent() ?

[yzshen1, 2013/09/03 21:04:26]

(forgive me if I misunderstand this)

I thought whether to use TargetIsSubframe/TargetIsMainFrame is determined by
|target|, not |frame|. Maybe we should use |target_frame| as line 2775?

[Bernhard Bauer, 2013/09/03 21:15:09]

Hm, I think we don't have a target in all cases, i.e. |target_frame| could be
NULL. Would that mean that the navigation would happen in |frame|?

[yzshen1, 2013/09/03 21:19:42]

I don't know the answer. I think we could look into the implementation of
loadFrameRequest().

On 2013/09/03 21:15:09, Bernhard Bauer wrote:

[Bernhard Bauer, 2013/09/03 21:59:27]

Hm, I think so; see
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit....

Updated the code to that effect, PTAL?

+                               WebURLRequest::TargetIsSubframe :
+                               WebURLRequest::TargetIsMainFrame,
                            frame,
-                           &web_request))
+                           &web_request)) {
     return PP_ERROR_FAILED;
+  }
+
   web_request.setFirstPartyForCookies(document.firstPartyForCookies());
   web_request.setHasUserGesture(from_user_action);