Don't set the request target type to object when navigating from a Pepper plug-in.

content/renderer/pepper/pepper_plugin_instance_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_plugin_instance_impl.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
@@ skipping 2739 matching lines @@
 
   WebDocument document = container_->element().document();
   WebFrame* frame = document.frame();
   if (!frame)
     return PP_ERROR_FAILED;
 
   ppapi::URLRequestInfoData completed_request = request;
 
   WebURLRequest web_request;
   if (!CreateWebURLRequest(&completed_request,
-                           WebURLRequest::TargetIsMainFrame,
+                           frame->parent() ?

[yzshen1, 2013/09/03 21:04:26]

(forgive me if I misunderstand this)

I thought whether to use TargetIsSubframe/TargetIsMainFrame is determined by
|target|, not |frame|. Maybe we should use |target_frame| as line 2775?

[Bernhard Bauer, 2013/09/03 21:15:09]

Hm, I think we don't have a target in all cases, i.e. |target_frame| could be
NULL. Would that mean that the navigation would happen in |frame|?

[yzshen1, 2013/09/03 21:19:42]

I don't know the answer. I think we could look into the implementation of
loadFrameRequest().

On 2013/09/03 21:15:09, Bernhard Bauer wrote:

[Bernhard Bauer, 2013/09/03 21:59:27]

Hm, I think so; see
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit....

Updated the code to that effect, PTAL?

+                               WebURLRequest::TargetIsSubframe :
+                               WebURLRequest::TargetIsMainFrame,
                            frame,
-                           &web_request))
+                           &web_request)) {
     return PP_ERROR_FAILED;
+  }
+
   web_request.setFirstPartyForCookies(document.firstPartyForCookies());
   web_request.setHasUserGesture(from_user_action);
 
   GURL gurl(web_request.url());
   if (gurl.SchemeIs("javascript")) {
     // In imitation of the NPAPI implementation, only |target_frame == frame| is
     // allowed for security reasons.
     WebFrame* target_frame =
         frame->view()->findFrameByName(WebString::fromUTF8(target), frame);
     if (target_frame != frame)
@@ skipping 135 matching lines @@
     // Running out-of-process. Initiate an IPC call to notify the plugin
     // process.
     ppapi::proxy::HostDispatcher* dispatcher =
         ppapi::proxy::HostDispatcher::GetForInstance(pp_instance());
     dispatcher->Send(new PpapiMsg_PPPInstance_HandleDocumentLoad(
         ppapi::API_ID_PPP_INSTANCE, pp_instance(), pending_host_id, data));
   }
 }
 
 }  // namespace content