Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2354733002: DevTools: remove UISourceCodeFrame from context when switching panels. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

DevTools: remove UISourceCodeFrame from context when switching panels. BUG=640375 Review-Url: https://codereview.chromium.org/2314503005 Cr-Commit-Position: refs/heads/master@{#417120} (cherry picked from commit 0256fbaededb2fd7db51f5559d9656ceebc3e736) Committed: https://chromium.googlesource.com/chromium/src/+/1339ab8e8254ab8264805bcb9ac367b5254e9ff4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 2 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js View 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js View 2 chunks +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Context.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pfeldman
4 years, 3 months ago (2016-09-19 21:26:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1339ab8e8254ab8264805bcb9ac367b5254e9ff4 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698