Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2314503005: DevTools: remove UISourceCodeFrame from context when switching panels. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 3 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove UISourceCodeFrame from context when switching panels. BUG=640375 Committed: https://crrev.com/0256fbaededb2fd7db51f5559d9656ceebc3e736 Cr-Commit-Position: refs/heads/master@{#417120}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 2 chunks +17 lines, -1 line 1 comment Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js View 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js View 2 chunks +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Context.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pfeldman
4 years, 3 months ago (2016-09-06 21:10:06 UTC) #2
alph
lgtm https://codereview.chromium.org/2314503005/diff/1/third_party/WebKit/Source/devtools/front_end/Runtime.js File third_party/WebKit/Source/devtools/front_end/Runtime.js (right): https://codereview.chromium.org/2314503005/diff/1/third_party/WebKit/Source/devtools/front_end/Runtime.js#newcode933 third_party/WebKit/Source/devtools/front_end/Runtime.js:933: if (!contextTypes) nit: return contextTypes && contextTypes.some(type => ...
4 years, 3 months ago (2016-09-06 23:07:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314503005/1
4 years, 3 months ago (2016-09-07 22:26:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 23:51:05 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 23:53:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0256fbaededb2fd7db51f5559d9656ceebc3e736
Cr-Commit-Position: refs/heads/master@{#417120}

Powered by Google App Engine
This is Rietveld 408576698