Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2354683002: DevTools: clean up BUILD.gn (Closed)

Created:
4 years, 3 months ago by chenwilliam
Modified:
4 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: clean up BUILD.gn - removes debug switch that I deprecated in previous CL https://crrev.com/2336943002 - makes the build applications GN rules more DRY BUG=none Committed: https://crrev.com/a66d94b07598badf58f0e341e57d9b53dd6955dd Cr-Commit-Position: refs/heads/master@{#419604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -30 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 3 chunks +20 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chenwilliam
PTAL.
4 years, 3 months ago (2016-09-19 18:35:15 UTC) #2
pfeldman
lgtm
4 years, 3 months ago (2016-09-19 22:52:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354683002/1
4 years, 3 months ago (2016-09-19 22:54:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 23:57:05 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 23:59:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a66d94b07598badf58f0e341e57d9b53dd6955dd
Cr-Commit-Position: refs/heads/master@{#419604}

Powered by Google App Engine
This is Rietveld 408576698