Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/devtools/BUILD.gn

Issue 2354683002: DevTools: clean up BUILD.gn (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/BUILD.gn
diff --git a/third_party/WebKit/Source/devtools/BUILD.gn b/third_party/WebKit/Source/devtools/BUILD.gn
index f933be2113a8e574ff7910d1be0c5786cb46c236..7ff7b8e0209ce88a19d7be8b831dc95b90263346 100644
--- a/third_party/WebKit/Source/devtools/BUILD.gn
+++ b/third_party/WebKit/Source/devtools/BUILD.gn
@@ -907,6 +907,14 @@ generated_remote_modules = [
"$resources_out_dir/screencast/screencast_module.js",
]
+devtools_applications = [
+ "inspector",
+ "toolbox",
+ "formatter_worker",
+ "heap_snapshot_worker",
+ "temp_storage_shared_worker",
+]
+
#-------------------------------------------------------------------------------
visibility = [ "//third_party/WebKit/*" ]
@@ -1053,21 +1061,12 @@ action("build_release_devtools") {
outputs = generated_entry_files + generated_workers +
generated_bundled_modules + generated_remote_modules
- debug_mode = "0"
-
- args = [
- "inspector",
- "toolbox",
- "formatter_worker",
- "heap_snapshot_worker",
- "temp_storage_shared_worker",
- "--input_path",
- rebase_path("front_end", root_build_dir),
- "--output_path",
- rebase_path(resources_out_dir, root_build_dir),
- "--debug",
- debug_mode,
- ]
+ args = devtools_applications + [
+ "--input_path",
+ rebase_path("front_end", root_build_dir),
+ "--output_path",
+ rebase_path(resources_out_dir, root_build_dir),
+ ]
}
if (debug_devtools) {
@@ -1090,21 +1089,12 @@ if (debug_devtools) {
"$resources_out_debug_dir/toolbox.html",
]
- debug_mode = "1"
-
- args = [
- "inspector",
- "toolbox",
- "formatter_worker",
- "heap_snapshot_worker",
- "temp_storage_shared_worker",
- "--input_path",
- rebase_path("front_end", root_build_dir),
- "--output_path",
- rebase_path(resources_out_debug_dir, root_build_dir),
- "--debug",
- debug_mode,
- ]
+ args = devtools_applications + [
+ "--input_path",
+ rebase_path("front_end", root_build_dir),
+ "--output_path",
+ rebase_path(resources_out_debug_dir, root_build_dir),
+ ]
}
copy("copy_generated_scripts") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698