Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2007)

Unified Diff: chrome/BUILD.gn

Issue 2354633002: Add //chrome/browser/ui to "gn check". (Closed)
Patch Set: cast_shell_android and chromeos_ozone Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | chrome/app/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 36cad983fc6a72f38b796c113764bedccb0574d0..66291fcb0991191ceb85b73a7eef8da8d343d3f2 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -295,8 +295,6 @@ if (is_win) {
sources = [
"//base/win/dllmain.cc",
- "app/chrome_dll.rc",
- "app/chrome_dll_resource.h",
"app/chrome_main.cc",
"app/chrome_main_delegate.cc",
"app/chrome_main_delegate.h",
@@ -307,6 +305,7 @@ if (is_win) {
deps = [
":browser_dependencies",
"//build/config/sanitizers:deps",
+ "//chrome/app:chrome_dll_resources",
"//chrome/app:command_ids",
"//chrome/common:features",
"//third_party/cld",
@@ -1165,7 +1164,8 @@ group("browser_dependencies") {
# all blink targets.
"//third_party/WebKit/public:blink",
# TODO(brettw) bug 581766: V8 should not be linked into the browser
- # process, and then we can enable this.
+ # process, and then we can enable this. When testing whether you can
+ # enable this, run with a non-component build.
#"//v8/*",
]
}
« no previous file with comments | « .gn ('k') | chrome/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698