Issue 23546002: Fix test for warn_unused_result and move it to v8config.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23546002: Fix test for warn_unused_result and move it to v8config.h. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer

Modified:
7 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix test for warn_unused_result and move it to v8config.h. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16347

Patch Set 2 : Suggest new GCC attribute syntax. #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -20 lines)			Patch
	M	include/v8config.h	View	1	6 chunks	+39 lines, -15 lines	0 comments	Download
	M	src/globals.h	View		1 chunk	+2 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (rubber-stamped). https://codereview.chromium.org/23546002/diff/4001/src/globals.h File src/globals.h (right): https://codereview.chromium.org/23546002/diff/4001/src/globals.h#newcode360 src/globals.h:360: // Newly written code should use V8_WARN_UNUSED_RESULT. ...

7 years, 3 months ago (2013-08-27 08:23:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r16347.

Expand Messages | Collapse Messages

Issue 23546002: Fix test for warn_unused_result and move it to v8config.h. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Suggest new GCC attribute syntax. #

Messages