src/globals.h - Issue 23546002: Fix test for warn_unused_result and move it to v8config.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/globals.h

Issue 23546002: Fix test for warn_unused_result and move it to v8config.h. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Suggest new GCC attribute syntax. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/globals.h

diff --git a/src/globals.h b/src/globals.h

index 2d072a001b5d654a9048ef6ab2577d00439ed328..1a6e5ec45ffe4989fc64bba95d8571ce5dbbd9b5 100644

--- a/src/globals.h

+++ b/src/globals.h

@@ -357,11 +357,8 @@ F FUNCTION_CAST(Address addr) {

#endif

-#if defined(__GNUC__) && __GNUC__ >= 4

-#define MUST_USE_RESULT __attribute__ ((warn_unused_result))

-#else

-#define MUST_USE_RESULT

-#endif

+// Newly written code should use V8_WARN_UNUSED_RESULT.

Michael Starzinger 2013/08/27 08:23:43 Thanks for not touching another 528 occurrences of

+#define MUST_USE_RESULT V8_WARN_UNUSED_RESULT

// Define DISABLE_ASAN macros.

« no previous file with comments | « include/v8config.h ('k') | no next file » | no next file with comments »