Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2354533005: FormData should not drop ignorable code points. (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FormData should not drop ignorable code points. UCNV_FROM_U_CALLBACK_ESCAPE() used for EntitiesForUnencodables removes "ignorable" characters. We should avoid to use it. BUG=647568 Committed: https://crrev.com/65267c78144e27387dcc19b75c79407b904f8f1c Cr-Commit-Position: refs/heads/master@{#420897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M third_party/WebKit/Source/wtf/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecICU.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecICU.cpp View 3 chunks +9 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/wtf/text/TextCodecICUTest.cpp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
tkent
jshin@, would you review this please?
4 years, 3 months ago (2016-09-21 10:58:25 UTC) #7
tkent
jshin is ooo. Keishi, would you review this please?
4 years, 2 months ago (2016-09-26 05:57:20 UTC) #9
keishi
LGTM
4 years, 2 months ago (2016-09-26 06:05:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354533005/1
4 years, 2 months ago (2016-09-26 06:09:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/299424)
4 years, 2 months ago (2016-09-26 07:39:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354533005/1
4 years, 2 months ago (2016-09-26 08:20:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147885)
4 years, 2 months ago (2016-09-26 10:10:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354533005/1
4 years, 2 months ago (2016-09-26 10:31:35 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147921)
4 years, 2 months ago (2016-09-26 12:59:28 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354533005/1
4 years, 2 months ago (2016-09-26 14:39:33 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 15:58:02 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 16:00:36 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65267c78144e27387dcc19b75c79407b904f8f1c
Cr-Commit-Position: refs/heads/master@{#420897}

Powered by Google App Engine
This is Rietveld 408576698