Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: third_party/WebKit/Source/wtf/text/TextCodecICU.h

Issue 2354533005: FormData should not drop ignorable code points. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/BUILD.gn ('k') | third_party/WebKit/Source/wtf/text/TextCodecICU.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/text/TextCodecICU.h
diff --git a/third_party/WebKit/Source/wtf/text/TextCodecICU.h b/third_party/WebKit/Source/wtf/text/TextCodecICU.h
index 9b34d647c12eaeaa55a42ec1fcdfd05767adcecb..d74f0038d92cc8d91436edf37d52dafdfc481638 100644
--- a/third_party/WebKit/Source/wtf/text/TextCodecICU.h
+++ b/third_party/WebKit/Source/wtf/text/TextCodecICU.h
@@ -27,6 +27,7 @@
#ifndef TextCodecICU_h
#define TextCodecICU_h
+#include "base/gtest_prod_util.h"
#include "wtf/text/TextCodec.h"
#include "wtf/text/TextEncoding.h"
#include <memory>
@@ -47,7 +48,7 @@ public:
private:
TextCodecICU(const TextEncoding&);
- static std::unique_ptr<TextCodec> create(const TextEncoding&, const void*);
+ WTF_EXPORT static std::unique_ptr<TextCodec> create(const TextEncoding&, const void*);
String decode(const char*, size_t length, FlushBehavior, bool stopOnError, bool& sawError) override;
CString encode(const UChar*, size_t length, UnencodableHandling) override;
@@ -72,6 +73,8 @@ private:
#if defined(USING_SYSTEM_ICU)
mutable bool m_needsGBKFallbacks;
#endif
+
+ FRIEND_TEST_ALL_PREFIXES(TextCodecICUTest, IgnorableCodePoint);
};
struct ICUConverterWrapper {
« no previous file with comments | « third_party/WebKit/Source/wtf/BUILD.gn ('k') | third_party/WebKit/Source/wtf/text/TextCodecICU.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698