Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Issue 2354513002: Update comment about TODO in verify_source_deps.py (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update comment about TODO in verify_source_deps.py Forgot to include that in the previous CL TBR=machenbach@chromium.org BUG= Committed: https://crrev.com/1d75f17c634bfad453c631a037e7dd410e2571c5 Cr-Commit-Position: refs/heads/master@{#39500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/verify_source_deps.py View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-09-19 11:04:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354513002/1
4 years, 3 months ago (2016-09-19 11:04:31 UTC) #3
Michael Achenbach
lgtm add NOTRY=true ? As we don't have sophisticated analyze logic in V8. Spilled milk ...
4 years, 3 months ago (2016-09-19 11:06:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 11:40:21 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 11:41:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d75f17c634bfad453c631a037e7dd410e2571c5
Cr-Commit-Position: refs/heads/master@{#39500}

Powered by Google App Engine
This is Rietveld 408576698