Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: tools/verify_source_deps.py

Issue 2354513002: Update comment about TODO in verify_source_deps.py (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2015 the V8 project authors. All rights reserved. 2 # Copyright 2015 the V8 project authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 Script to print potentially missing source dependencies based on the actual 7 Script to print potentially missing source dependencies based on the actual
8 .h and .cc files in the source tree and which files are included in the gyp 8 .h and .cc files in the source tree and which files are included in the gyp
9 and gn files. The latter inclusion is overapproximated. 9 and gn files. The latter inclusion is overapproximated.
10 10
11 TODO(machenbach): Gyp files in src will point to source files in src without a 11 TODO(machenbach): If two source files with the same name exist, but only one
12 src/ prefix. For simplicity, all paths relative to src are stripped. But this 12 is referenced from a gyp/gn file, we won't necessarily detect it.
13 tool won't be accurate for other sources in other directories (e.g. cctest).
14 """ 13 """
15 14
16 import itertools 15 import itertools
17 import re 16 import re
18 import os 17 import os
19 import sys 18 import sys
20 19
21 20
22 V8_BASE = os.path.dirname(os.path.dirname(os.path.realpath(__file__))) 21 V8_BASE = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
23 V8_SRC_BASE = os.path.join(V8_BASE, 'src') 22 V8_SRC_BASE = os.path.join(V8_BASE, 'src')
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 for i in missing_gyp_files(): 159 for i in missing_gyp_files():
161 print i 160 print i
162 161
163 print "\n----------- Files not in gn: -------------" 162 print "\n----------- Files not in gn: -------------"
164 for i in missing_gn_files(): 163 for i in missing_gn_files():
165 print i 164 print i
166 return 0 165 return 0
167 166
168 if '__main__' == __name__: 167 if '__main__' == __name__:
169 sys.exit(main()) 168 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698